Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-2.1: [fix](iceberg)Fix count(*) error with dangling delete problem #44039 #44101

Merged
merged 1 commit into from
Nov 19, 2024
Merged

branch-2.1: [fix](iceberg)Fix count(*) error with dangling delete problem #44039 #44101

merged 1 commit into from
Nov 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #44039

@wuwenchi
[fix](iceberg)Fix count(*) error with dangling delete problem (#44039)
d4d67ff 
### What problem does this PR solve?

Prevent 'dangling delete' problem after `rewrite_data_files` action.
ref:
https://iceberg.apache.org/docs/nightly/spark-procedures/#rewrite_position_delete_files.

Because we don’t know whether the user has performed a rewrite
operation, `total-records` will only be used directly when
equalitydelete and positiondelete are both 0.

Issue Number: close #42240
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

run buildall

@yiguolei yiguolei closed this Nov 18, 2024
@yiguolei yiguolei reopened this Nov 18, 2024
@yiguolei yiguolei merged commit 83b7482 into branch-2.1 Nov 19, 2024
20 of 21 checks passed
@github-actions github-actions bot deleted the auto-pick-44039-branch-2.1 branch November 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doris-robot @yiguolei @wuwenchi