Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wg](chore) rename workload group memory property names #44028

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

jacktengg
Copy link
Contributor

@jacktengg jacktengg commented Nov 15, 2024

What problem does this PR solve?

This is a property behaviour change. Since spill disk is not many used, we can change its name.

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Mannual test steps:

  1. With old FE and BE, modify properties to new value:
alter workload group normal properties("spill_threshold_low_watermark"="55%");
alter workload group normal properties("spill_threshold_high_watermark"="85%");
  1. Update BE to the modified code, check that values are the update values in step 1.
  2. Modify properties values again:
alter workload group normal properties("spill_threshold_low_watermark"="60%");
alter workload group normal properties("spill_threshold_high_watermark"="90%");
  1. Update FE to the modified code, check that values are the update values in step 3.
  2. Modify properties values again:
alter workload group normal properties("memory_low_watermark"="65%"); 
alter workload group normal properties("memory_high_watermark"="95%"); 

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@jacktengg
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.00% (9902/26057)
Line Coverage: 29.19% (82746/283518)
Region Coverage: 28.32% (42501/150097)
Branch Coverage: 24.89% (21550/86586)
Coverage Report: http://coverage.selectdb-in.cc/coverage/759e5c308116ae50d3c5b4d7c1b8656d48f4f1ab_759e5c308116ae50d3c5b4d7c1b8656d48f4f1ab/report/index.html

yiguolei
yiguolei previously approved these changes Nov 16, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 16, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@jacktengg jacktengg force-pushed the fix-1114 branch 2 times, most recently from 6528d41 to 6329684 Compare November 19, 2024 08:25
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 19, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@jacktengg
Copy link
Contributor Author

run buildall

yiguolei
yiguolei previously approved these changes Nov 19, 2024
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 19, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

wangbo
wangbo previously approved these changes Nov 19, 2024
Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.01% (9899/26042)
Line Coverage: 29.19% (82768/283550)
Region Coverage: 28.33% (42516/150067)
Branch Coverage: 24.89% (21555/86592)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6329684f99c3727f3d117e5295879986fc81dbcf_6329684f99c3727f3d117e5295879986fc81dbcf/report/index.html

@jacktengg
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@jacktengg
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.02% (9899/26035)
Line Coverage: 29.22% (82839/283540)
Region Coverage: 28.34% (42523/150055)
Branch Coverage: 24.91% (21566/86584)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9deb6948d62d20236f5595d8e88d89c37aa54ace_9deb6948d62d20236f5595d8e88d89c37aa54ace/report/index.html

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit ee9252a into apache:master Nov 20, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants