Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Support TCP Keep-Alive on MySQL connections #43904

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[enhancement] Support TCP Keep-Alive on MySQL connections #43904

merged 3 commits into from
Dec 5, 2024

Conversation

lide-reed
Copy link
Contributor

The default behavior of Options.KEEP_ALIVE is typically disabled, meaning that TCP keep-alive is not enabled by default. This means that if you do not explicitly enable it, the connection will not send keep-alive probes when idle.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

liutang123
liutang123 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@liutang123 liutang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

xy720
xy720 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lide-reed
Copy link
Contributor Author

run buildall

@lide-reed lide-reed merged commit 6b7c12f into apache:master Dec 5, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@xy720 xy720 xy720 approved these changes

@liutang123 liutang123 liutang123 approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lide-reed @doris-robot @liutang123 @xy720 @morrySnow