Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](s3filewriter) Optimize exception handling when put object #43809

Merged
merged 3 commits into from
Nov 14, 2024
Merged

[opt](s3filewriter) Optimize exception handling when put object #43809

merged 3 commits into from
Nov 14, 2024

Conversation

gavinchou
Copy link
Contributor

we should not continue to put object if state is not satisfied.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou gavinchou force-pushed the gavin-opt-s3-file-writer-log branch from 801f46b to d64f159 Compare November 12, 2024 17:24
@gavinchou
Copy link
Contributor Author

run buidall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring
Copy link
Contributor

run buildall

@gavinchou gavinchou force-pushed the gavin-opt-s3-file-writer-log branch from d64f159 to 59f33e0 Compare November 13, 2024 09:01
@gavinchou
Copy link
Contributor Author

run

@gavinchou
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.94% (9888/26063)
Line Coverage: 29.14% (82650/283614)
Region Coverage: 28.26% (42467/150254)
Branch Coverage: 24.85% (21544/86694)
Coverage Report: http://coverage.selectdb-in.cc/coverage/654b4089073d1cd05b5d762bcc6015d1d91d3772_654b4089073d1cd05b5d762bcc6015d1d91d3772/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou merged commit b9fb461 into apache:master Nov 14, 2024
24 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 14, 2024
@gavinchou
[opt](s3filewriter) Optimize exception handling when put object (#43809)
a5a2d2f 
we should not continue to put object if state is not satisfied.
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
Merged
gavinchou added a commit that referenced this pull request Nov 14, 2024
@github-actions @gavinchou
branch-3.0: [opt](s3filewriter) Optimize exception handling when put …
74f48b6 
…object #43809 (#43964)

Cherry-picked from #43809

Co-authored-by: Gavin Chou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

@SWJTU-ZhangLei SWJTU-ZhangLei SWJTU-ZhangLei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gavinchou @doris-robot @dataroaring @SWJTU-ZhangLei @Yukang-Lian