Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test #43611

Closed
wants to merge 1 commit into from
Closed

test #43611

wants to merge 1 commit into from

Conversation

zhangstar333
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@zhangstar333
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp
}

template <bool BuildSide, bool IsSemi>
void NestedLoopJoinProbeLocalStateCross::_finalize_current_phase(vectorized::Block& block,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function '_finalize_current_phase' has cognitive complexity of 74 (threshold 50) [readability-function-cognitive-complexity]

void NestedLoopJoinProbeLocalStateCross::_finalize_current_phase(vectorized::Block& block,
                                         ^
Additional context

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:147: +1, including nesting penalty of 0, nesting level increased to 1

    if constexpr (BuildSide) {
    ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:151: +2, including nesting penalty of 1, nesting level increased to 2

        for (; i < build_block_sz && column_size < batch_size; i++) {
        ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:151: +1

        for (; i < build_block_sz && column_size < batch_size; i++) {
                                  ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:162: +3, including nesting penalty of 2, nesting level increased to 3

            for (uint32_t j = 0; j < num_rows; j++) {
            ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:163: +4, including nesting penalty of 3, nesting level increased to 4

                if constexpr (IsSemi) {
                ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:164: +5, including nesting penalty of 4, nesting level increased to 5

                    if (cur_visited_flags[j]) {
                    ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:167: +1, nesting level increased to 4

                } else {
                  ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:168: +5, including nesting penalty of 4, nesting level increased to 5

                    if (!cur_visited_flags[j]) {
                    ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:175: +3, including nesting penalty of 2, nesting level increased to 3

            for (size_t j = 0; j < p._num_probe_side_columns; ++j) {
            ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:182: +3, including nesting penalty of 2, nesting level increased to 3

            for (size_t j = 0; j < p._num_build_side_columns; ++j) {
            ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:184: +4, including nesting penalty of 3, nesting level increased to 4

                if (!src_column.column->is_nullable() &&
                ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:184: +1

                if (!src_column.column->is_nullable() &&
                                                      ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:197: +1, nesting level increased to 4

                } else {
                  ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:206: +1, nesting level increased to 1

    } else {
      ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:207: +2, including nesting penalty of 1, nesting level increased to 2

        if (!p._is_mark_join) {
        ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:210: +3, including nesting penalty of 2, nesting level increased to 3

            for (int j = _left_block_start_pos;
            ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:212: +4, including nesting penalty of 3, nesting level increased to 4

                if (_cur_probe_row_visited_flags[j] == IsSemi) {
                ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:214: +5, including nesting penalty of 4, nesting level increased to 5

                    for (size_t i = 0; i < p._num_probe_side_columns; ++i) {
                    ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:217: +6, including nesting penalty of 5, nesting level increased to 6

                        if (!src_column.column->is_nullable() && dst_columns[i]->is_nullable()) {
                        ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:217: +1

                        if (!src_column.column->is_nullable() && dst_columns[i]->is_nullable()) {
                                                              ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:226: +1, nesting level increased to 6

                        } else {
                          ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:232: +3, including nesting penalty of 2, nesting level increased to 3

            if (new_size > column_size) {
            ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:233: +4, including nesting penalty of 3, nesting level increased to 4

                for (size_t i = 0; i < p._num_build_side_columns; ++i) {
                ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:239: +1, nesting level increased to 2

        } else {
          ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:243: +3, including nesting penalty of 2, nesting level increased to 3

            for (int j = _left_block_start_pos;
            ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:247: +3, including nesting penalty of 2, nesting level increased to 3

            for (size_t i = 0; i < p._num_probe_side_columns; ++i) {
            ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:254: +3, including nesting penalty of 2, nesting level increased to 3

            for (size_t i = 0; i < p._num_build_side_columns; ++i) {
            ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp
}

template <bool BuildSide, bool IsSemi>
void NestedLoopJoinProbeLocalStateCross::_finalize_current_phase(vectorized::Block& block,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function '_finalize_current_phase' exceeds recommended size/complexity thresholds [readability-function-size]

void NestedLoopJoinProbeLocalStateCross::_finalize_current_phase(vectorized::Block& block,
                                         ^
Additional context

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.cpp:141: 120 lines including whitespace and comments (threshold 80)

void NestedLoopJoinProbeLocalStateCross::_finalize_current_phase(vectorized::Block& block,
                                         ^

be/src/pipeline/exec/nested_loop_join_probe_operator_cross.h

#pragma once

#include <stdint.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cstdint' instead [modernize-deprecated-headers]

Suggested change
#include <stdint.h>
#include <cstdint>

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.75% (9846/26083)
Line Coverage: 29.04% (82375/283619)
Region Coverage: 28.13% (42327/150478)
Branch Coverage: 24.75% (21458/86706)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7551d0867a89eeeb848ba60b222e58c21c34e8c8_7551d0867a89eeeb848ba60b222e58c21c34e8c8/report/index.html

@zhangstar333
Copy link
Contributor Author

run buildall

@zhangstar333
Copy link
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangstar333 @doris-robot