Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](regression) Fix flaky test fault_injection_p0/cloud/test_cloud_mow_stale_resp_load_load_conflict #43448

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Nov 7, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: ADMIN SET FRONTEND CONFIG() will only update the config of the connected FE, which may lead to unexpected result for some cases if the connected FE is not master FE. should use ADMIN SET FRONTEND CONFIG() instead.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@bobhan1
Copy link
Contributor Author

bobhan1 commented Nov 7, 2024

run buildall

@bobhan1
Copy link
Contributor Author

bobhan1 commented Nov 8, 2024

run cloud_p0

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen merged commit 9d72875 into apache:master Nov 13, 2024
32 of 34 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
…_mow_stale_resp_load_load_conflict` (#43448)

Problem Summary: `ADMIN SET FRONTEND CONFIG()` will only update the
config of the connected FE, which may lead to unexpected result for some
cases if the connected FE is not master FE. should use `ADMIN SET
FRONTEND CONFIG()` instead.
dataroaring pushed a commit that referenced this pull request Nov 14, 2024
…d/test_cloud_mow_stale_resp_load_load_conflict` (#43843)

Cherry-picked from #43448

Co-authored-by: bobhan1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants