Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](docker) add metaservice start console to docker entrypoint #43200

Merged

Conversation

catpineapple
Copy link
Contributor

@catpineapple catpineapple commented Nov 4, 2024

What problem does this PR solve?

  1. add metaservice start console to docker entrypoint. we can see the log details through kubectl logs
  2. add dcr workload group support to be_entrypoint.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@catpineapple
Copy link
Contributor Author

run buildall

intelligentfu8
intelligentfu8 previously approved these changes Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

PR approved by anyone and no changes requested.

@catpineapple
Copy link
Contributor Author

run buildall

@catpineapple
Copy link
Contributor Author

run buildall

Copy link
Contributor

@intelligentfu8 intelligentfu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 13, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@shuke987
Copy link
Collaborator

skip buildall

@intelligentfu8 intelligentfu8 merged commit 5695609 into apache:master Nov 13, 2024
29 of 30 checks passed
@catpineapple catpineapple deleted the add_ms_console_for_docker_entrypoint branch November 13, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants