Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] (nereids)implement showCharsetCommand in nereids #43155

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[Enhancement] (nereids)implement showCharsetCommand in nereids #43155

merged 1 commit into from
Dec 16, 2024

Conversation

msridhar78
Copy link
Contributor

@msridhar78 msridhar78 commented Nov 3, 2024 •
edited
Loading

Issue Number: close #42749

implement showCharsetCommand in nereids

mysql> show charset;
+---------+---------------+-------------------+--------+
| Charset | Description | Default collation | Maxlen |
+---------+---------------+-------------------+--------+
| utf8mb4 | UTF-8 Unicode | utf8mb4_0900_bin | 4 |
+---------+---------------+-------------------+--------+
1 row in set (0.00 sec)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41112 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9f8e5f527ffd711a3f947d6723660856c6055314, data reload: false

------ Round 1 ----------------------------------
q1	17568	7759	7300	7300
q2	2044	167	175	167
q3	10562	1081	1201	1081
q4	10510	847	761	761
q5	7780	2986	3045	2986
q6	236	146	143	143
q7	1009	624	586	586
q8	9350	1977	2018	1977
q9	6581	6422	6438	6422
q10	7043	2445	2401	2401
q11	470	255	261	255
q12	401	221	212	212
q13	17779	2997	3016	2997
q14	245	215	221	215
q15	576	522	508	508
q16	657	597	588	588
q17	969	542	544	542
q18	7317	6648	6772	6648
q19	1359	1033	992	992
q20	466	181	183	181
q21	3933	3174	3170	3170
q22	1104	1017	980	980
Total cold run time: 107959 ms
Total hot run time: 41112 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7262	7237	7243	7237
q2	329	225	226	225
q3	2987	2933	2967	2933
q4	2091	1919	1767	1767
q5	5737	5783	5758	5758
q6	232	143	143	143
q7	2309	1892	1853	1853
q8	3445	3577	3516	3516
q9	8986	8965	9015	8965
q10	3558	3546	3552	3546
q11	599	520	549	520
q12	833	639	609	609
q13	10348	3178	3206	3178
q14	308	279	298	279
q15	576	516	515	515
q16	690	640	660	640
q17	1866	1637	1659	1637
q18	8279	7652	7611	7611
q19	1696	1551	1674	1551
q20	2069	1891	1879	1879
q21	5528	5518	5583	5518
q22	1141	1069	1060	1060
Total cold run time: 70869 ms
Total hot run time: 60940 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196241 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9f8e5f527ffd711a3f947d6723660856c6055314, data reload: false

query1	1200	919	882	882
query2	6209	2205	2187	2187
query3	10795	3973	3883	3883
query4	67719	29252	23607	23607
query5	4869	450	429	429
query6	398	175	191	175
query7	5598	287	291	287
query8	318	224	223	223
query9	8946	2747	2722	2722
query10	442	261	249	249
query11	17313	15201	16030	15201
query12	154	97	97	97
query13	1524	433	432	432
query14	11198	7016	7246	7016
query15	210	181	179	179
query16	7044	466	471	466
query17	1005	559	548	548
query18	1814	294	289	289
query19	192	149	145	145
query20	115	110	108	108
query21	201	100	97	97
query22	4675	4372	4445	4372
query23	34532	34043	34170	34043
query24	5979	2721	2723	2721
query25	530	395	401	395
query26	643	157	154	154
query27	1680	273	286	273
query28	4342	2455	2438	2438
query29	692	424	426	424
query30	245	151	158	151
query31	982	802	814	802
query32	62	56	54	54
query33	415	271	266	266
query34	903	517	511	511
query35	860	748	721	721
query36	1082	962	957	957
query37	120	72	75	72
query38	4359	4326	4343	4326
query39	1458	1424	1434	1424
query40	200	97	98	97
query41	48	45	45	45
query42	106	91	95	91
query43	546	517	500	500
query44	1161	838	814	814
query45	185	162	167	162
query46	1115	680	687	680
query47	1964	1901	1914	1901
query48	412	317	350	317
query49	741	416	399	399
query50	811	396	388	388
query51	7203	7134	7164	7134
query52	103	89	88	88
query53	250	179	182	179
query54	530	397	426	397
query55	78	74	74	74
query56	247	239	234	234
query57	1292	1149	1137	1137
query58	223	200	204	200
query59	3308	3180	3254	3180
query60	260	239	237	237
query61	106	107	102	102
query62	794	682	662	662
query63	218	186	183	183
query64	1354	628	620	620
query65	3250	3181	3226	3181
query66	706	299	302	299
query67	16221	15984	15783	15783
query68	3400	559	569	559
query69	426	273	250	250
query70	1217	1142	1069	1069
query71	361	255	254	254
query72	6218	3899	3985	3899
query73	742	352	350	350
query74	10104	8971	9054	8971
query75	3370	2647	2644	2644
query76	1881	1097	1109	1097
query77	493	306	304	304
query78	10390	9426	9402	9402
query79	1429	586	583	583
query80	871	426	425	425
query81	513	247	243	243
query82	1285	116	116	116
query83	188	139	139	139
query84	278	69	67	67
query85	874	296	291	291
query86	341	284	303	284
query87	4915	4646	4607	4607
query88	3774	2199	2143	2143
query89	414	297	292	292
query90	2028	182	179	179
query91	137	99	99	99
query92	75	48	48	48
query93	1941	529	529	529
query94	837	286	299	286
query95	352	245	241	241
query96	614	275	285	275
query97	2964	2713	2691	2691
query98	213	202	201	201
query99	1580	1293	1318	1293
Total cold run time: 318480 ms
Total hot run time: 196241 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.93 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9f8e5f527ffd711a3f947d6723660856c6055314, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.22	0.06	0.06
query4	1.64	0.10	0.10
query5	0.43	0.41	0.39
query6	1.15	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.57	0.50	0.50
query10	0.54	0.55	0.56
query11	0.14	0.10	0.10
query12	0.14	0.12	0.11
query13	0.61	0.60	0.59
query14	2.70	2.70	2.77
query15	0.90	0.82	0.83
query16	0.38	0.38	0.38
query17	1.08	0.98	1.07
query18	0.19	0.19	0.20
query19	1.94	1.79	1.96
query20	0.02	0.01	0.01
query21	15.36	0.58	0.56
query22	2.71	2.84	1.27
query23	17.01	1.13	0.75
query24	3.33	1.24	1.37
query25	0.39	0.07	0.05
query26	0.47	0.13	0.14
query27	0.04	0.05	0.04
query28	10.04	1.09	1.07
query29	12.60	3.24	3.27
query30	0.24	0.06	0.06
query31	2.87	0.38	0.37
query32	3.30	0.45	0.46
query33	3.02	3.02	3.03
query34	17.15	4.42	4.42
query35	4.47	4.47	4.44
query36	0.70	0.49	0.49
query37	0.09	0.07	0.05
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107 s
Total hot run time: 31.93 s

@LiBinfeng-01
Copy link
Collaborator

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41506 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 414a7d791a5c345f1dd66b75bb6f993eedf10274, data reload: false

------ Round 1 ----------------------------------
q1	17560	7461	7301	7301
q2	2037	161	183	161
q3	10634	1086	1170	1086
q4	10225	876	844	844
q5	7751	3094	3096	3094
q6	234	147	151	147
q7	1035	618	605	605
q8	9369	1949	2007	1949
q9	6535	6467	6474	6467
q10	7121	2457	2455	2455
q11	460	256	251	251
q12	412	220	215	215
q13	17769	3006	3024	3006
q14	240	209	205	205
q15	575	516	513	513
q16	668	595	594	594
q17	972	554	622	554
q18	7264	6805	6812	6805
q19	1330	1057	949	949
q20	458	180	180	180
q21	4004	3341	3131	3131
q22	1136	1011	994	994
Total cold run time: 107789 ms
Total hot run time: 41506 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7331	7330	7335	7330
q2	322	236	227	227
q3	3017	2974	2992	2974
q4	2100	1848	1826	1826
q5	5714	5756	5861	5756
q6	226	142	143	142
q7	2232	1846	1802	1802
q8	3442	3498	3545	3498
q9	8923	8955	8881	8881
q10	3633	3580	3600	3580
q11	617	521	499	499
q12	833	621	660	621
q13	11299	3186	3189	3186
q14	307	272	274	272
q15	561	514	525	514
q16	692	640	650	640
q17	1865	1657	1638	1638
q18	8362	7836	7645	7645
q19	1724	1458	1563	1458
q20	2104	1867	1893	1867
q21	5625	5444	5749	5444
q22	1141	1087	1062	1062
Total cold run time: 72070 ms
Total hot run time: 60862 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197332 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 414a7d791a5c345f1dd66b75bb6f993eedf10274, data reload: false

query1	1189	924	922	922
query2	6222	2141	2156	2141
query3	10905	3975	4036	3975
query4	67822	31117	23900	23900
query5	4941	446	448	446
query6	293	184	164	164
query7	4903	295	296	295
query8	275	231	240	231
query9	6402	2745	2739	2739
query10	408	254	247	247
query11	15730	15241	15972	15241
query12	160	101	101	101
query13	1057	441	417	417
query14	10592	7626	7434	7434
query15	209	184	195	184
query16	7138	516	471	471
query17	1038	574	566	566
query18	1819	303	303	303
query19	204	153	155	153
query20	113	108	116	108
query21	206	103	101	101
query22	4845	4319	4575	4319
query23	34450	34247	34168	34168
query24	6075	2820	2798	2798
query25	481	367	377	367
query26	637	153	151	151
query27	1685	290	289	289
query28	4253	2403	2389	2389
query29	660	409	404	404
query30	235	147	149	147
query31	964	803	796	796
query32	66	53	52	52
query33	381	256	260	256
query34	921	514	515	514
query35	883	731	730	730
query36	1094	975	979	975
query37	124	72	70	70
query38	4346	4248	4325	4248
query39	1449	1410	1461	1410
query40	193	100	96	96
query41	47	42	44	42
query42	108	105	97	97
query43	542	506	494	494
query44	1151	801	828	801
query45	186	159	169	159
query46	1129	689	685	685
query47	1946	1855	1837	1837
query48	423	329	308	308
query49	715	371	380	371
query50	808	399	403	399
query51	7308	7179	7024	7024
query52	101	84	85	84
query53	260	179	180	179
query54	506	388	399	388
query55	76	72	75	72
query56	259	223	237	223
query57	1297	1159	1149	1149
query58	211	206	215	206
query59	3438	3088	2943	2943
query60	271	243	249	243
query61	102	112	102	102
query62	775	682	687	682
query63	224	188	184	184
query64	1321	703	612	612
query65	3331	3197	3254	3197
query66	703	318	297	297
query67	16019	15863	15914	15863
query68	2198	565	588	565
query69	409	270	254	254
query70	1191	1153	1132	1132
query71	328	256	254	254
query72	6276	4286	4091	4091
query73	763	354	364	354
query74	9529	9029	9003	9003
query75	3421	2672	2690	2672
query76	1559	1058	1077	1058
query77	467	296	284	284
query78	10559	9425	9472	9425
query79	1272	596	590	590
query80	809	417	432	417
query81	526	242	241	241
query82	212	121	120	120
query83	153	156	137	137
query84	278	75	69	69
query85	940	296	295	295
query86	330	297	289	289
query87	4836	4772	4838	4772
query88	3912	2196	2172	2172
query89	412	294	301	294
query90	2035	190	185	185
query91	137	101	103	101
query92	59	51	47	47
query93	1542	543	546	543
query94	828	295	282	282
query95	348	249	250	249
query96	609	279	284	279
query97	2877	2694	2698	2694
query98	216	208	199	199
query99	1604	1317	1306	1306
Total cold run time: 309260 ms
Total hot run time: 197332 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.2 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 414a7d791a5c345f1dd66b75bb6f993eedf10274, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.03	0.03
query3	0.22	0.07	0.07
query4	1.64	0.10	0.11
query5	0.42	0.39	0.43
query6	1.17	0.65	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.55	0.48	0.49
query10	0.54	0.56	0.54
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.59	0.60
query14	2.78	2.83	2.79
query15	0.89	0.82	0.83
query16	0.38	0.38	0.38
query17	1.07	1.05	1.03
query18	0.20	0.19	0.20
query19	1.90	1.73	2.01
query20	0.01	0.00	0.01
query21	15.36	0.61	0.56
query22	2.85	1.89	2.26
query23	16.93	0.95	0.81
query24	3.36	1.60	2.29
query25	0.37	0.08	0.24
query26	0.49	0.14	0.13
query27	0.04	0.05	0.04
query28	9.16	1.09	1.08
query29	12.56	3.32	3.27
query30	0.24	0.06	0.07
query31	2.87	0.38	0.39
query32	3.27	0.47	0.45
query33	2.99	2.97	3.03
query34	17.07	4.49	4.51
query35	4.63	4.52	4.56
query36	0.66	0.49	0.49
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.13 s
Total hot run time: 33.2 s

@msridhar78 msridhar78 marked this pull request as draft November 4, 2024 04:40
@msridhar78 msridhar78 marked this pull request as ready for review November 4, 2024 16:33
Vallishp
Vallishp reviewed Nov 28, 2024
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowCharsetCommand.java Outdated
/**
* Represents the command for SHOW CHARSETG
*/
public class ShowCharsetCommand extends Command implements NoForward {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use ShowCommand

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40281 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 77d56d230b68f17736691a69812af3a3c84e9806, data reload: false

------ Round 1 ----------------------------------
q1	17654	7535	7269	7269
q2	2060	182	178	178
q3	10620	1088	1253	1088
q4	10275	720	802	720
q5	7619	2781	2751	2751
q6	247	145	145	145
q7	1003	634	599	599
q8	9245	1893	1972	1893
q9	6720	6603	6521	6521
q10	6977	2322	2335	2322
q11	464	263	256	256
q12	424	215	213	213
q13	17767	3013	3023	3013
q14	239	209	220	209
q15	576	519	526	519
q16	672	612	592	592
q17	994	596	617	596
q18	7440	6919	6835	6835
q19	1348	1013	893	893
q20	484	179	181	179
q21	3949	3249	3172	3172
q22	382	318	323	318
Total cold run time: 107159 ms
Total hot run time: 40281 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7249	7238	7197	7197
q2	336	227	230	227
q3	2910	2882	2931	2882
q4	2071	1852	1897	1852
q5	5663	5703	5631	5631
q6	232	145	149	145
q7	2255	1811	1831	1811
q8	3454	3568	3549	3549
q9	9096	9031	9061	9031
q10	3566	3588	3546	3546
q11	592	514	495	495
q12	802	627	605	605
q13	12058	3186	3205	3186
q14	306	264	278	264
q15	587	545	528	528
q16	701	641	621	621
q17	1866	1670	1605	1605
q18	8474	7715	7750	7715
q19	1719	1573	1507	1507
q20	2106	1878	1873	1873
q21	5907	5513	5478	5478
q22	642	550	587	550
Total cold run time: 72592 ms
Total hot run time: 60298 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196854 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 77d56d230b68f17736691a69812af3a3c84e9806, data reload: false

query1	1247	976	980	976
query2	6244	2105	2018	2018
query3	10994	4463	4276	4276
query4	67276	29434	23461	23461
query5	5050	457	450	450
query6	421	179	177	177
query7	5656	294	292	292
query8	313	229	246	229
query9	9348	2736	2722	2722
query10	462	256	241	241
query11	17228	15186	15665	15186
query12	157	100	109	100
query13	1586	419	436	419
query14	9929	7201	7162	7162
query15	214	190	183	183
query16	7177	480	470	470
query17	1452	637	563	563
query18	1822	316	295	295
query19	201	155	158	155
query20	115	112	146	112
query21	209	104	100	100
query22	4820	4654	4746	4654
query23	34651	34277	34504	34277
query24	5423	2468	2437	2437
query25	509	372	407	372
query26	642	144	149	144
query27	1884	286	280	280
query28	4476	2508	2455	2455
query29	655	415	402	402
query30	202	158	157	157
query31	1007	799	829	799
query32	71	52	57	52
query33	447	291	286	286
query34	941	521	515	515
query35	913	772	746	746
query36	1064	956	975	956
query37	120	79	75	75
query38	4585	4361	4448	4361
query39	1521	1441	1469	1441
query40	207	96	101	96
query41	44	43	43	43
query42	111	99	95	95
query43	540	488	510	488
query44	1172	864	806	806
query45	193	173	166	166
query46	1164	714	713	713
query47	2053	1906	1972	1906
query48	404	313	335	313
query49	730	385	389	385
query50	864	384	392	384
query51	7480	7044	7017	7017
query52	99	84	87	84
query53	247	171	180	171
query54	496	392	396	392
query55	74	72	75	72
query56	254	225	249	225
query57	1259	1118	1125	1118
query58	220	213	209	209
query59	3386	2902	3103	2902
query60	264	239	236	236
query61	100	110	120	110
query62	791	679	661	661
query63	212	182	198	182
query64	1390	693	639	639
query65	3270	3199	3190	3190
query66	704	306	300	300
query67	15914	15856	15617	15617
query68	4349	556	546	546
query69	421	254	253	253
query70	1205	1087	1107	1087
query71	351	255	241	241
query72	6498	4280	3983	3983
query73	757	353	359	353
query74	10184	8973	9023	8973
query75	3377	2654	2641	2641
query76	1897	1154	1086	1086
query77	476	273	279	273
query78	11404	11120	9941	9941
query79	2693	595	601	595
query80	1131	413	423	413
query81	522	232	239	232
query82	633	124	118	118
query83	202	140	141	140
query84	272	63	67	63
query85	751	299	293	293
query86	467	305	311	305
query87	4614	4469	4622	4469
query88	4197	2216	2237	2216
query89	419	293	289	289
query90	2171	196	192	192
query91	136	101	108	101
query92	67	51	52	51
query93	2006	539	535	535
query94	824	291	292	291
query95	348	245	242	242
query96	627	275	274	274
query97	2896	2639	2690	2639
query98	215	189	194	189
query99	1558	1343	1314	1314
Total cold run time: 322342 ms
Total hot run time: 196854 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.44 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 77d56d230b68f17736691a69812af3a3c84e9806, data reload: false

query1	0.03	0.02	0.04
query2	0.06	0.04	0.03
query3	0.23	0.07	0.07
query4	1.63	0.11	0.10
query5	0.42	0.42	0.42
query6	1.14	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.57	0.52	0.51
query10	0.54	0.57	0.56
query11	0.14	0.11	0.11
query12	0.14	0.11	0.12
query13	0.61	0.60	0.60
query14	2.71	2.72	2.71
query15	0.89	0.84	0.83
query16	0.39	0.39	0.39
query17	1.04	1.08	1.09
query18	0.22	0.22	0.22
query19	1.92	1.80	1.98
query20	0.01	0.01	0.01
query21	15.36	0.59	0.56
query22	2.33	2.14	2.53
query23	17.16	0.98	0.79
query24	2.86	0.57	0.47
query25	0.16	0.15	0.20
query26	0.45	0.15	0.14
query27	0.04	0.04	0.05
query28	11.56	1.10	1.07
query29	12.60	3.22	3.22
query30	0.24	0.06	0.06
query31	2.86	0.38	0.37
query32	3.31	0.46	0.47
query33	3.01	3.00	3.02
query34	17.12	4.54	4.45
query35	4.47	4.53	4.46
query36	0.66	0.49	0.48
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.16	0.13	0.14
query41	0.09	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.41 s
Total hot run time: 32.44 s

@LiBinfeng-01
Copy link
Collaborator

run cloud_p0

@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39678 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1b5ed0d9df0daab9db4a0a6b33292ab6144b6ceb, data reload: false

------ Round 1 ----------------------------------
q1	17605	7381	7264	7264
q2	2041	171	178	171
q3	10794	1056	1199	1056
q4	10571	772	731	731
q5	7610	2663	2616	2616
q6	265	147	149	147
q7	993	618	596	596
q8	9242	1817	1918	1817
q9	6613	6591	6526	6526
q10	7047	2258	2277	2258
q11	467	264	255	255
q12	438	232	224	224
q13	17803	3035	2976	2976
q14	246	220	207	207
q15	583	542	506	506
q16	661	578	571	571
q17	966	505	546	505
q18	7257	6649	6675	6649
q19	1369	946	1075	946
q20	457	180	180	180
q21	3999	3177	3188	3177
q22	373	323	300	300
Total cold run time: 107400 ms
Total hot run time: 39678 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7286	7303	7241	7241
q2	324	227	230	227
q3	2903	2752	2945	2752
q4	2091	1853	1875	1853
q5	5669	5694	5641	5641
q6	225	138	140	138
q7	2236	1797	1801	1797
q8	3395	3576	3476	3476
q9	8966	9012	8996	8996
q10	3564	3561	3572	3561
q11	588	514	504	504
q12	812	614	620	614
q13	11092	3262	3222	3222
q14	299	263	270	263
q15	574	516	515	515
q16	685	634	645	634
q17	1861	1627	1636	1627
q18	8178	7799	7739	7739
q19	1691	1633	1516	1516
q20	2145	1883	1873	1873
q21	5492	5449	5395	5395
q22	639	606	575	575
Total cold run time: 70715 ms
Total hot run time: 60159 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196919 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1b5ed0d9df0daab9db4a0a6b33292ab6144b6ceb, data reload: false

query1	1259	939	919	919
query2	6233	2107	2029	2029
query3	10940	4349	4395	4349
query4	67406	28948	23643	23643
query5	4971	467	470	467
query6	409	176	168	168
query7	5546	311	296	296
query8	301	230	230	230
query9	8826	2633	2639	2633
query10	445	249	257	249
query11	17410	15150	15900	15150
query12	151	102	107	102
query13	1510	456	431	431
query14	10489	7610	6873	6873
query15	217	192	194	192
query16	7165	482	476	476
query17	1287	599	597	597
query18	1795	313	308	308
query19	213	164	198	164
query20	123	115	115	115
query21	206	111	98	98
query22	4822	4521	4609	4521
query23	35020	34676	34792	34676
query24	5388	2499	2490	2490
query25	490	392	380	380
query26	651	152	157	152
query27	1901	280	284	280
query28	4302	2482	2492	2482
query29	679	419	397	397
query30	204	152	145	145
query31	1052	845	861	845
query32	65	54	56	54
query33	453	294	286	286
query34	941	524	525	524
query35	902	761	752	752
query36	1087	984	952	952
query37	121	78	81	78
query38	4536	4384	4389	4384
query39	1482	1476	1523	1476
query40	198	99	105	99
query41	45	46	42	42
query42	106	101	95	95
query43	539	500	499	499
query44	1194	817	839	817
query45	193	180	163	163
query46	1175	722	719	719
query47	2018	1933	1919	1919
query48	408	308	327	308
query49	723	381	379	379
query50	845	393	397	393
query51	7453	7179	6975	6975
query52	96	83	93	83
query53	251	177	176	176
query54	514	394	389	389
query55	83	84	71	71
query56	244	224	231	224
query57	1254	1134	1118	1118
query58	210	200	199	199
query59	3311	3015	3110	3015
query60	275	238	240	238
query61	115	132	108	108
query62	808	684	657	657
query63	206	184	198	184
query64	1400	667	660	660
query65	3255	3216	3207	3207
query66	711	290	310	290
query67	16063	15672	15683	15672
query68	4012	573	567	567
query69	437	256	246	246
query70	1222	1097	1143	1097
query71	360	244	237	237
query72	6419	4057	4134	4057
query73	762	344	346	344
query74	10245	9217	9064	9064
query75	3413	2674	2654	2654
query76	1959	1099	1123	1099
query77	481	262	265	262
query78	10403	9496	9363	9363
query79	1852	601	622	601
query80	1341	426	417	417
query81	508	239	229	229
query82	1300	117	112	112
query83	190	152	140	140
query84	275	66	66	66
query85	987	299	297	297
query86	415	266	286	266
query87	4766	4564	4486	4486
query88	3695	2146	2126	2126
query89	421	297	290	290
query90	1945	178	181	178
query91	142	99	102	99
query92	65	49	51	49
query93	2374	567	545	545
query94	817	295	296	295
query95	384	240	246	240
query96	622	271	281	271
query97	2896	2654	2672	2654
query98	212	192	206	192
query99	1660	1314	1331	1314
Total cold run time: 321271 ms
Total hot run time: 196919 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1b5ed0d9df0daab9db4a0a6b33292ab6144b6ceb, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.08	0.07
query4	1.61	0.11	0.10
query5	0.42	0.41	0.40
query6	1.16	0.66	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.57	0.51	0.51
query10	0.56	0.57	0.55
query11	0.14	0.10	0.10
query12	0.14	0.10	0.11
query13	0.61	0.61	0.59
query14	2.85	2.74	2.72
query15	0.89	0.82	0.83
query16	0.37	0.37	0.39
query17	1.06	0.99	1.01
query18	0.23	0.21	0.21
query19	1.94	1.86	2.03
query20	0.02	0.01	0.01
query21	15.35	0.59	0.58
query22	2.95	1.79	1.62
query23	17.00	0.93	0.73
query24	2.99	1.40	1.80
query25	0.26	0.09	0.17
query26	0.44	0.15	0.14
query27	0.04	0.05	0.04
query28	9.70	1.10	1.07
query29	12.55	3.25	3.26
query30	0.24	0.06	0.06
query31	2.87	0.39	0.38
query32	3.26	0.46	0.46
query33	2.98	3.02	3.01
query34	17.15	4.48	4.46
query35	4.55	4.46	4.46
query36	0.67	0.48	0.49
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.02	0.03
query40	0.15	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.02	0.02
Total cold run time: 106.44 s
Total hot run time: 32.68 s

@msridhar78
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39721 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1b5ed0d9df0daab9db4a0a6b33292ab6144b6ceb, data reload: false

------ Round 1 ----------------------------------
q1	17612	7372	7246	7246
q2	2045	180	168	168
q3	10559	1121	1158	1121
q4	10228	742	747	742
q5	7591	2719	2717	2717
q6	234	150	148	148
q7	1015	624	621	621
q8	9247	1811	1926	1811
q9	6712	6494	6469	6469
q10	7000	2279	2284	2279
q11	474	256	253	253
q12	416	226	220	220
q13	17787	3013	3030	3013
q14	248	220	212	212
q15	554	524	522	522
q16	686	572	587	572
q17	965	514	664	514
q18	7429	6619	6504	6504
q19	1329	1031	955	955
q20	451	182	185	182
q21	3961	3220	3136	3136
q22	374	316	318	316
Total cold run time: 106917 ms
Total hot run time: 39721 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7212	7279	7198	7198
q2	329	235	234	234
q3	2911	2764	2988	2764
q4	2156	1819	1784	1784
q5	5506	5711	5632	5632
q6	220	139	140	139
q7	2192	1798	1726	1726
q8	3336	3506	3501	3501
q9	8978	8950	9028	8950
q10	3600	3547	3538	3538
q11	595	495	497	495
q12	814	602	598	598
q13	13347	3247	3141	3141
q14	294	283	284	283
q15	571	513	530	513
q16	693	625	639	625
q17	1790	1554	1565	1554
q18	7880	7450	7581	7450
q19	1651	1518	1516	1516
q20	2017	1790	1822	1790
q21	5406	5271	5166	5166
q22	675	541	576	541
Total cold run time: 72173 ms
Total hot run time: 59138 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190582 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1b5ed0d9df0daab9db4a0a6b33292ab6144b6ceb, data reload: false

query1	973	371	368	368
query2	6523	2100	2044	2044
query3	6693	225	215	215
query4	34280	23519	23452	23452
query5	4391	465	446	446
query6	289	188	181	181
query7	4625	304	302	302
query8	308	240	237	237
query9	9736	2647	2637	2637
query10	484	248	242	242
query11	18098	15169	15332	15169
query12	150	99	105	99
query13	1650	411	407	407
query14	9718	6808	7051	6808
query15	254	172	179	172
query16	8197	454	486	454
query17	1674	587	567	567
query18	2152	300	300	300
query19	368	160	153	153
query20	150	114	107	107
query21	205	101	98	98
query22	4649	4195	4211	4195
query23	34999	34365	34098	34098
query24	11432	2464	2444	2444
query25	673	384	376	376
query26	1802	155	153	153
query27	2925	271	281	271
query28	8185	2436	2443	2436
query29	1029	397	393	393
query30	302	148	149	148
query31	1052	818	814	814
query32	95	54	58	54
query33	759	282	279	279
query34	1051	488	558	488
query35	905	727	730	727
query36	1130	929	965	929
query37	282	72	77	72
query38	4261	4189	4253	4189
query39	1478	1426	1441	1426
query40	284	99	96	96
query41	44	43	44	43
query42	109	98	97	97
query43	536	490	510	490
query44	1230	797	793	793
query45	184	159	160	159
query46	1168	699	692	692
query47	1977	1891	1849	1849
query48	417	310	309	309
query49	1295	383	380	380
query50	808	382	375	375
query51	7217	7224	7160	7160
query52	96	91	85	85
query53	262	181	178	178
query54	1203	410	399	399
query55	83	79	79	79
query56	261	235	232	232
query57	1264	1157	1125	1125
query58	220	208	224	208
query59	3214	3063	2920	2920
query60	267	239	247	239
query61	107	116	125	116
query62	862	686	698	686
query63	233	196	192	192
query64	5138	670	629	629
query65	3295	3225	3244	3225
query66	1430	321	313	313
query67	16120	15827	15776	15776
query68	4886	560	580	560
query69	415	245	258	245
query70	1215	1137	1147	1137
query71	346	249	243	243
query72	6354	4075	4078	4075
query73	744	360	354	354
query74	10445	9067	8853	8853
query75	3458	2650	2737	2650
query76	2831	1099	1087	1087
query77	484	263	262	262
query78	10586	9596	9450	9450
query79	1339	590	602	590
query80	991	440	424	424
query81	534	234	225	225
query82	1245	115	126	115
query83	246	153	140	140
query84	230	66	68	66
query85	1353	291	289	289
query86	354	302	255	255
query87	4780	4611	4484	4484
query88	3230	2171	2116	2116
query89	408	301	299	299
query90	2122	192	189	189
query91	135	102	103	102
query92	60	51	52	51
query93	1069	542	551	542
query94	1044	292	294	292
query95	354	255	251	251
query96	611	275	274	274
query97	2847	2646	2685	2646
query98	211	198	193	193
query99	1551	1349	1328	1328
Total cold run time: 303729 ms
Total hot run time: 190582 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.05 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1b5ed0d9df0daab9db4a0a6b33292ab6144b6ceb, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.02	0.04
query3	0.23	0.07	0.07
query4	1.62	0.10	0.11
query5	0.41	0.43	0.42
query6	1.17	0.65	0.64
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.51	0.51
query10	0.55	0.56	0.56
query11	0.14	0.10	0.10
query12	0.15	0.11	0.12
query13	0.61	0.61	0.60
query14	2.81	2.84	2.75
query15	0.92	0.83	0.83
query16	0.37	0.38	0.40
query17	1.06	1.06	1.00
query18	0.22	0.21	0.20
query19	1.96	1.91	2.10
query20	0.01	0.01	0.01
query21	15.37	0.60	0.57
query22	2.23	2.02	1.65
query23	17.17	0.89	0.88
query24	3.61	0.55	0.67
query25	0.35	0.15	0.07
query26	0.40	0.13	0.14
query27	0.04	0.05	0.05
query28	11.10	1.10	1.07
query29	12.55	3.23	3.23
query30	0.25	0.06	0.06
query31	2.87	0.40	0.38
query32	3.25	0.46	0.46
query33	3.00	3.00	3.03
query34	16.96	4.42	4.48
query35	4.50	4.56	4.46
query36	0.68	0.48	0.49
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.18	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.04
Total cold run time: 107.79 s
Total hot run time: 32.05 s

starocean999
starocean999 reviewed Dec 11, 2024
View reviewed changes
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4 Outdated
@@ -228,6 +228,7 @@ supportedShowStatement
| SHOW DYNAMIC PARTITION TABLES ((FROM | IN) database=multipartIdentifier)? #showDynamicPartition
| SHOW EVENTS ((FROM | IN) database=multipartIdentifier)? wildWhere? #showEvents
| SHOW LAST INSERT #showLastInsert
| SHOW ((CHAR SET) | CHARSET) wildWhere? #showCharset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| SHOW ((CHAR SET) | CHARSET) wildWhere? #showCharset
| SHOW ((CHAR SET) | CHARSET) #showCharset

Since wildWhere is useless, we can remove it for simplicity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done - pls review

@msridhar78
Copy link
Contributor Author

run buildall

Vallishp
Vallishp approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Vallishp Vallishp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 40715 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 360fabdae59ccfa8624818aac90da77e2ec3556a, data reload: false

------ Round 1 ----------------------------------
q1	17600	7716	7516	7516
q2	2042	185	186	185
q3	10682	1138	1250	1138
q4	10550	818	698	698
q5	7617	2827	2758	2758
q6	258	147	149	147
q7	1022	635	602	602
q8	9258	1919	2004	1919
q9	6937	6665	6686	6665
q10	7087	2331	2316	2316
q11	480	250	254	250
q12	453	226	220	220
q13	17784	3017	2997	2997
q14	233	203	211	203
q15	561	525	519	519
q16	663	578	591	578
q17	1015	617	531	531
q18	7320	6676	6751	6676
q19	1346	1156	999	999
q20	487	184	182	182
q21	4190	3426	3307	3307
q22	365	309	335	309
Total cold run time: 107950 ms
Total hot run time: 40715 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7576	7527	7527	7527
q2	343	221	225	221
q3	3035	3012	3032	3012
q4	2232	1980	1888	1888
q5	5691	5722	5759	5722
q6	242	148	148	148
q7	2312	1831	1813	1813
q8	3530	3798	3699	3699
q9	9093	9108	9089	9089
q10	3712	3669	3592	3592
q11	611	521	501	501
q12	855	623	593	593
q13	12714	3213	3209	3209
q14	318	288	280	280
q15	586	510	534	510
q16	685	640	656	640
q17	1997	1770	1688	1688
q18	8310	7804	7538	7538
q19	1905	1842	1768	1768
q20	2133	1938	1872	1872
q21	5698	5654	5588	5588
q22	649	567	597	567
Total cold run time: 74227 ms
Total hot run time: 61465 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195857 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 360fabdae59ccfa8624818aac90da77e2ec3556a, data reload: false

query1	1250	976	920	920
query2	6247	2092	2094	2092
query3	10991	4378	4141	4141
query4	66619	28445	23359	23359
query5	4953	466	445	445
query6	430	187	184	184
query7	5523	311	288	288
query8	329	241	234	234
query9	8635	2709	2703	2703
query10	438	246	252	246
query11	17090	15061	15697	15061
query12	159	102	103	102
query13	1475	448	454	448
query14	10890	7216	7127	7127
query15	227	183	195	183
query16	7065	504	492	492
query17	1071	577	608	577
query18	1413	302	304	302
query19	209	156	158	156
query20	119	112	150	112
query21	203	106	106	106
query22	4834	4568	4549	4549
query23	34196	33908	34603	33908
query24	5503	2481	2473	2473
query25	492	387	385	385
query26	734	149	149	149
query27	2043	284	287	284
query28	4937	2517	2476	2476
query29	671	404	394	394
query30	208	152	151	151
query31	1019	845	818	818
query32	74	53	57	53
query33	447	283	293	283
query34	977	516	523	516
query35	883	776	787	776
query36	1071	969	943	943
query37	124	74	71	71
query38	4464	4456	4416	4416
query39	1496	1446	1421	1421
query40	193	101	100	100
query41	52	47	48	47
query42	109	96	94	94
query43	552	511	518	511
query44	1203	837	861	837
query45	189	168	169	168
query46	1159	712	697	697
query47	2077	1948	1929	1929
query48	419	342	354	342
query49	730	391	394	391
query50	841	382	379	379
query51	7367	7079	7233	7079
query52	95	84	110	84
query53	256	176	171	171
query54	508	393	389	389
query55	81	81	73	73
query56	257	227	236	227
query57	1255	1094	1122	1094
query58	215	210	206	206
query59	3192	3214	3117	3117
query60	279	241	234	234
query61	105	104	107	104
query62	803	665	679	665
query63	210	190	183	183
query64	2474	661	637	637
query65	3212	3165	3204	3165
query66	692	302	294	294
query67	15936	15587	15485	15485
query68	4083	564	572	564
query69	428	261	246	246
query70	1196	1094	1162	1094
query71	393	242	243	242
query72	5997	4122	3995	3995
query73	784	360	353	353
query74	10017	8861	8897	8861
query75	3401	2657	2663	2657
query76	1912	1148	1118	1118
query77	514	328	273	273
query78	10384	9411	9457	9411
query79	2162	618	606	606
query80	890	417	496	417
query81	507	229	240	229
query82	292	122	118	118
query83	169	143	136	136
query84	283	68	68	68
query85	1050	307	294	294
query86	410	286	310	286
query87	4697	4525	4579	4525
query88	4464	2200	2182	2182
query89	410	291	291	291
query90	2081	182	181	181
query91	132	105	102	102
query92	70	49	49	49
query93	2404	559	560	559
query94	843	295	284	284
query95	343	238	243	238
query96	629	275	275	275
query97	2895	2689	2652	2652
query98	209	196	191	191
query99	1593	1325	1314	1314
Total cold run time: 319612 ms
Total hot run time: 195857 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.63 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 360fabdae59ccfa8624818aac90da77e2ec3556a, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.62	0.11	0.10
query5	0.42	0.41	0.42
query6	1.13	0.65	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.49
query10	0.55	0.58	0.55
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.60
query14	2.80	2.75	2.81
query15	0.90	0.83	0.83
query16	0.39	0.37	0.38
query17	1.03	1.06	1.08
query18	0.21	0.22	0.21
query19	1.84	1.73	2.00
query20	0.02	0.01	0.01
query21	15.35	0.62	0.56
query22	2.41	3.17	2.05
query23	17.01	0.85	0.77
query24	3.07	2.08	0.95
query25	0.24	0.22	0.08
query26	0.52	0.13	0.13
query27	0.04	0.04	0.04
query28	10.05	1.11	1.07
query29	12.53	3.21	3.18
query30	0.25	0.06	0.06
query31	2.89	0.38	0.37
query32	3.28	0.46	0.46
query33	2.95	3.06	3.06
query34	17.00	4.45	4.43
query35	4.47	4.52	4.51
query36	0.64	0.48	0.47
query37	0.10	0.06	0.05
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.14	0.13
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.95 s
Total hot run time: 32.63 s

@starocean999 starocean999 merged commit 4ef95fa into apache:master Dec 16, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@Vallishp Vallishp Vallishp approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement showCharsetCommand in nereids
5 participants
@msridhar78 @doris-robot @LiBinfeng-01 @Vallishp @starocean999