[feat](metrics) Unify metrics of thread pool #43144
Open
+393
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
TeamCity be ut coverage result: |
|
run buildall |
|
run buildall |
1 similar comment
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
Fail of test has nothing to do with this pr. |
wangbo
reviewed
Nov 5, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zhiqiang-hhhh
force-pushed
the
metrics-scan
branch
from
7eb8642 to
5928144
Compare
zhiqiang-hhhh
force-pushed
the
metrics-scan
branch
from
5928144 to
2a36bd5
Compare
|
run buildall |
zhiqiang-hhhh
changed the title
|
run buildall |
|
run buildall |
1 similar comment
|
run buildall |
zhiqiang-hhhh
force-pushed
the
metrics-scan
branch
from
06d35d8 to
f23c627
Compare
|
run buildall |
zhiqiang-hhhh
force-pushed
the
metrics-scan
branch
from
fc8a649 to
47474ba
Compare
|
run buildall |
yiguolei
reviewed
Dec 20, 2024
be/src/util/threadpool.cpp
Outdated
| #include "util/thread.h" | ||
|
|
||
| namespace doris { | ||
|
|
||
| // The name of these varialbs will be useds as metric name in prometheus. | ||
| DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(thread_pool_running_tasks, MetricUnit::NOUNIT); |
github-actions
bot
removed
the
approved
yiguolei
reviewed
Dec 20, 2024
zhiqiang-hhhh
force-pushed
the
metrics-scan
branch
from
ada5aeb to
2e538b3
Compare
|
run buildall |
zhiqiang-hhhh
force-pushed
the
metrics-scan
branch
from
2e538b3 to
614c0c9
Compare
|
run buildall |
TPC-H: Total hot run time: 40126 ms |
TPC-DS: Total hot run time: 189275 ms |
ClickBench: Total hot run time: 32.99 s |
yiguolei
reviewed
Dec 23, 2024
| @@ -139,7 +139,6 @@ namespace doris { | |||
| class PBackendService_Stub; | |||
| class PFunctionService_Stub; | |||
|
|
|||
| DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(scanner_thread_pool_queue_size, MetricUnit::NOUNIT); | |||
| DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(send_batch_thread_pool_thread_num, MetricUnit::NOUNIT); | |||
There was a problem hiding this comment.
_send_batch_thread_pool 这个相关的监控，可以不考虑兼容性，直接迁移到通用的thread pool 监控里
yiguolei
reviewed
Dec 23, 2024
| #include "gutil/integral_types.h" | ||
|
|
||
| namespace doris { | ||
|
|
yiguolei
reviewed
Dec 23, 2024
| @@ -269,10 +286,35 @@ Status ThreadPool::init() { | |||
| return status; | |||
| } | |||
| } | |||
|
|
|||
| _metric_entity = DorisMetrics::instance()->metric_registry()->register_entity( | |||
There was a problem hiding this comment.
如果有两个workload group，里面都有scan thread pool， 此时register entity的时候，注册2次，但是pool 的名字是相同的，此时是什么行为？
There was a problem hiding this comment.
当一个workload group 删除的时候，调用deregister的时候，把这个entity 删除了，另外一个workload group 是什么行为？
There was a problem hiding this comment.
pool name不会相同，pool name 的后缀是 wg 的name
yiguolei
reviewed
Dec 23, 2024
be/src/util/threadpool.cpp
Outdated
| // Get the next token and task to execute. | ||
| ThreadPoolToken* token = _queue.front(); | ||
| _queue.pop_front(); | ||
| DCHECK_EQ(ThreadPoolToken::State::RUNNING, token->state()); | ||
| DCHECK(!token->_entries.empty()); | ||
| Task task = std::move(token->_entries.front()); | ||
| std::chrono::time_point<std::chrono::system_clock> current = |
yiguolei
reviewed
Dec 23, 2024
| return Status::OK(); | ||
| } | ||
|
|
||
| void ThreadPool::shutdown() { | ||
| DorisMetrics::instance()->metric_registry()->deregister_entity(_metric_entity); |
There was a problem hiding this comment.
如果先deregister，假如此时还有task run，这个task run 结束之后，更新metric 会不会导致内存写脏？
There was a problem hiding this comment.
不会，metric的更新不是 thread pool做的，是当 Metrics 被外部系统请求的时候触发的更新，deregister 之后 map 里面就没有这个 metrics 了
zhiqiang-hhhh
force-pushed
the
metrics-scan
branch
from
614c0c9 to
d7e5f63
Compare
|
run buildall |
TPC-H: Total hot run time: 39916 ms |
TPC-DS: Total hot run time: 198366 ms |
ClickBench: Total hot run time: 32.67 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add metrics for all thread pool, more specifically, for all ThreadPool objects.
All thread pool will have following metrics:
A new class
IntervalHistogramStatis created for interval histogram calculation.Metrics is updated by
hookmethod when they are needed by prometheus.Check List (For Committer)
Test
Behavior changed:
Does this need documentation?
Release note
None
Check List (For Reviewer who merge this PR)