[Enhancement] (nereids)implement showRolesCommand in nereids #43118
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
| } | ||
|
|
||
| List<List<String>> infos = Env.getCurrentEnv().getAuth().getRoleInfo(); | ||
| ShowResultSet resultSet = new ShowResultSet(getMetaData(), infos); |
There was a problem hiding this comment.
remove getMetaData() method, use META_DATA directly
|
PR approved by anyone and no changes requested. |
| /** | ||
| * show roles command | ||
| */ | ||
| public class ShowRolesCommand extends Command implements NoForward { |
There was a problem hiding this comment.
The show command related features have some common logical need to be sorted out. I am working on the common part and the pr is #43271 . You can take it as a reference, the most important part is all show commands should inherent from ShowCommand and override the doRun method to do the real job.(you can move the code in run() function to doRun()) Sorry for the late change, you might have to wait the pr is merged and update all other show command prs accordingly.
There was a problem hiding this comment.
Ok. sure thanks. will handle all show related PR after merge of #43271
There was a problem hiding this comment.
@starocean999 i have updated as per your comments. Please help to review again. after that i will update all other show command PRs accordingly. thank you
Vallishp
force-pushed
the
nereids_show_role
branch
from
ad3a8b0 to
f1140f2
Compare
|
run buildall |
Vallishp
force-pushed
the
nereids_show_role
branch
from
f1140f2 to
328998c
Compare
|
run buildall |
|
run p0 |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
…43118) Issue Number: close apache#42768
…43118) Issue Number: close apache#42768
What problem does this PR solve?
Support show roles in nereids.
Issue Number: close #42768
Related PR: #xxx
Problem Summary:
Check List (For Committer)
Test
2024-11-08 03:37:22.042 INFO [suite-thread-1] (test_nereids_role.groovy:64) - roles_drop: [[admin, null, 'admin'@'%', Admin_priv, null, null, null, null, null, null, null, null, null], [operator, null, 'root'@'%', Node_priv,Admin_priv, null, null, null, null, null, null, null, null, null]]
2024-11-08 03:37:22.100 INFO [suite-thread-1] (ScriptContext.groovy:120) - Run test_nereids_role in /root/doris/workspace/doris/regression-test/suites/nereids_p0/ddl/account/test_nereids_role.groovy succeed
2024-11-08 03:37:52.786 INFO [main] (RegressionTest.groovy:281) - Start to run single scripts
2024-11-08 03:39:04.628 INFO [main] (RegressionTest.groovy:410) - Success suites:
/root/doris/workspace/doris/regression-test/suites/nereids_p0/ddl/account/test_nereids_role.groovy: group=default,p0, name=test_nereids_role
2024-11-08 03:39:04.629 INFO [main] (RegressionTest.groovy:492) - All suites success.
| _ \ / \ / / || | _
| |) / _ \ _ _ | | | | | |
| / ___ \ ) |) | || || |
|| // __//|_____|/
2024-11-08 03:39:04.629 INFO [main] (RegressionTest.groovy:440) - Test 1 suites, failed 0 suites, fatal 0 scripts, skipped 0 scripts
2024-11-08 03:39:04.629 INFO [main] (RegressionTest.groovy:126) - Test finished
Behavior changed:
Does this need documentation?
Release note
None
Check List (For Reviewer who merge this PR)