[improvement](build index)Optimize failed task check on same tablet #42295

qidaye · 2024-10-22T15:18:50Z

Proposed changes

Remove logic for replica majority failure checking
Introduce OBTAIN_LOCK_FAILED status code both in status.h and Status.thrift
Add MIN_FAILED_NUM = 3 for non try_lock_failed failure task. The task will try 3 times before canceling the job.
Add MAX_FAILED_NUM = 10 for try_lock_failed failure task. The task will try 10 times before canceling the job.

doris-robot · 2024-10-22T15:18:55Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

qidaye · 2024-10-22T15:19:01Z

run buildall

doris-robot · 2024-10-22T15:44:50Z

TPC-H: Total hot run time: 41517 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 173bb21a27b89f154710fcdae5e896a0c9583490, data reload: false

------ Round 1 ----------------------------------
q1	17602	8093	7245	7245
q2	2024	280	276	276
q3	12444	1419	1225	1225
q4	10232	865	911	865
q5	7779	3068	3058	3058
q6	236	156	156	156
q7	1001	629	597	597
q8	9350	1911	1994	1911
q9	6579	6452	6418	6418
q10	7088	2419	2442	2419
q11	445	234	256	234
q12	419	227	227	227
q13	17793	3012	3042	3012
q14	246	209	213	209
q15	566	527	520	520
q16	646	586	588	586
q17	969	572	512	512
q18	7548	6720	6778	6720
q19	1350	1010	1012	1010
q20	494	185	185	185
q21	3999	3146	3225	3146
q22	1101	986	1011	986
Total cold run time: 109911 ms
Total hot run time: 41517 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7261	7242	7241	7241
q2	347	258	258	258
q3	3131	2962	2951	2951
q4	2070	1791	1893	1791
q5	5623	5743	5820	5743
q6	231	148	150	148
q7	2191	1813	1814	1813
q8	3353	3547	3524	3524
q9	8909	8897	8939	8897
q10	3596	3591	3540	3540
q11	592	496	498	496
q12	858	634	625	625
q13	10006	3252	3187	3187
q14	315	278	286	278
q15	581	526	526	526
q16	710	631	631	631
q17	1829	1612	1603	1603
q18	8259	7762	7648	7648
q19	1686	1478	1481	1478
q20	2160	1955	1912	1912
q21	5707	5432	5490	5432
q22	1173	1070	1040	1040
Total cold run time: 70588 ms
Total hot run time: 60762 ms

doris-robot · 2024-10-22T15:56:54Z

TPC-DS: Total hot run time: 191886 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 173bb21a27b89f154710fcdae5e896a0c9583490, data reload: false

query1	823	362	378	362
query2	6247	2069	1978	1978
query3	8605	202	215	202
query4	34014	23662	23702	23662
query5	3686	470	462	462
query6	278	176	161	161
query7	4075	300	297	297
query8	303	240	231	231
query9	9188	2629	2628	2628
query10	470	273	284	273
query11	17846	15378	15300	15300
query12	151	111	102	102
query13	1519	436	417	417
query14	9772	7646	7216	7216
query15	248	172	177	172
query16	8068	450	474	450
query17	1635	622	573	573
query18	2140	324	332	324
query19	380	152	151	151
query20	126	127	124	124
query21	211	110	110	110
query22	4827	4791	4525	4525
query23	34857	33985	34204	33985
query24	10810	2731	2747	2731
query25	620	401	407	401
query26	1277	164	160	160
query27	2508	296	293	293
query28	7557	2440	2419	2419
query29	876	444	440	440
query30	259	151	156	151
query31	1057	786	814	786
query32	96	56	56	56
query33	784	294	299	294
query34	942	529	512	512
query35	881	769	756	756
query36	1114	986	952	952
query37	152	85	89	85
query38	4030	3958	3942	3942
query39	1485	1423	1418	1418
query40	257	102	100	100
query41	49	47	46	46
query42	123	97	99	97
query43	542	470	463	463
query44	1265	805	801	801
query45	198	166	164	164
query46	1144	680	700	680
query47	1918	1874	1850	1850
query48	419	316	323	316
query49	948	437	446	437
query50	812	382	412	382
query51	7063	7099	6896	6896
query52	98	88	90	88
query53	250	181	185	181
query54	1272	439	453	439
query55	78	83	79	79
query56	264	245	256	245
query57	1346	1175	1146	1146
query58	237	226	256	226
query59	3271	3104	2983	2983
query60	294	270	259	259
query61	106	104	106	104
query62	888	674	665	665
query63	234	194	194	194
query64	5183	661	612	612
query65	3310	3228	3201	3201
query66	1441	303	305	303
query67	16266	15612	15711	15612
query68	4531	552	545	545
query69	434	301	288	288
query70	1139	1085	1123	1085
query71	336	270	268	268
query72	6171	4081	3978	3978
query73	784	358	357	357
query74	10210	8983	9050	8983
query75	3383	2648	2671	2648
query76	2643	908	974	908
query77	395	303	293	293
query78	10508	9617	9534	9534
query79	1891	599	610	599
query80	2159	454	472	454
query81	579	236	243	236
query82	659	143	137	137
query83	278	134	138	134
query84	283	76	74	74
query85	1603	298	283	283
query86	412	298	297	297
query87	4352	4336	4408	4336
query88	2842	2255	2185	2185
query89	404	287	283	283
query90	2052	194	191	191
query91	138	104	103	103
query92	60	49	45	45
query93	2000	545	539	539
query94	1140	278	284	278
query95	353	250	250	250
query96	620	287	289	287
query97	3300	3119	3108	3108
query98	218	203	199	199
query99	1620	1311	1343	1311
Total cold run time: 300690 ms
Total hot run time: 191886 ms

doris-robot · 2024-10-22T16:02:23Z

ClickBench: Total hot run time: 31.56 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 173bb21a27b89f154710fcdae5e896a0c9583490, data reload: false

query1	0.03	0.03	0.04
query2	0.06	0.03	0.03
query3	0.22	0.07	0.06
query4	1.65	0.10	0.10
query5	0.51	0.52	0.49
query6	1.14	0.74	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.58	0.51	0.53
query10	0.54	0.55	0.54
query11	0.14	0.10	0.11
query12	0.14	0.11	0.10
query13	0.63	0.60	0.60
query14	2.74	2.76	2.74
query15	0.91	0.83	0.83
query16	0.38	0.37	0.37
query17	1.03	1.07	1.05
query18	0.24	0.22	0.23
query19	1.90	1.79	2.02
query20	0.01	0.01	0.02
query21	15.36	0.59	0.60
query22	2.62	1.96	1.26
query23	17.23	0.94	0.68
query24	3.64	0.34	0.54
query25	0.24	0.15	0.14
query26	0.38	0.14	0.14
query27	0.04	0.05	0.04
query28	11.41	1.08	1.06
query29	12.54	3.27	3.31
query30	0.24	0.06	0.05
query31	3.16	0.39	0.38
query32	3.25	0.45	0.47
query33	2.99	3.06	3.05
query34	16.88	4.46	4.49
query35	4.55	4.56	4.55
query36	0.68	0.47	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.15	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 108.58 s
Total hot run time: 31.56 s

airborne12

need tests

qidaye · 2024-10-30T12:42:08Z

run buildall

doris-robot · 2024-10-31T04:07:16Z

TPC-H: Total hot run time: 41259 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fca28fe6280c78fdab828ec4e21c3ba92db5abb6, data reload: false

------ Round 1 ----------------------------------
q1	17738	7695	7319	7319
q2	2047	161	179	161
q3	10784	1074	1191	1074
q4	10457	850	817	817
q5	7757	3108	3133	3108
q6	234	152	153	152
q7	1047	607	617	607
q8	9358	1976	2041	1976
q9	6621	6414	6531	6414
q10	7069	2415	2483	2415
q11	462	241	238	238
q12	410	224	220	220
q13	17779	2983	2986	2983
q14	247	213	214	213
q15	575	525	507	507
q16	658	593	595	593
q17	984	535	547	535
q18	7402	6772	6598	6598
q19	1348	1054	949	949
q20	474	179	182	179
q21	4072	3198	3242	3198
q22	1126	1021	1003	1003
Total cold run time: 108649 ms
Total hot run time: 41259 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7337	7269	7285	7269
q2	327	233	231	231
q3	3044	2985	2941	2941
q4	2065	1887	1785	1785
q5	5696	5727	5803	5727
q6	247	143	140	140
q7	2213	1808	1832	1808
q8	3420	3575	3450	3450
q9	8990	9025	8955	8955
q10	3660	3565	3552	3552
q11	596	485	506	485
q12	830	616	618	616
q13	11489	3192	3204	3192
q14	304	281	283	281
q15	576	524	519	519
q16	687	638	640	638
q17	1873	1623	1651	1623
q18	8341	7924	7714	7714
q19	1713	1641	1658	1641
q20	2115	1880	1858	1858
q21	5636	5442	5471	5442
q22	1181	1075	1050	1050
Total cold run time: 72340 ms
Total hot run time: 60917 ms

doris-robot · 2024-10-31T04:19:24Z

TPC-DS: Total hot run time: 195888 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fca28fe6280c78fdab828ec4e21c3ba92db5abb6, data reload: false

query1	1245	970	983	970
query2	6234	1996	1976	1976
query3	11607	4681	4848	4681
query4	33848	23632	23520	23520
query5	4768	456	442	442
query6	250	175	189	175
query7	3972	284	292	284
query8	267	214	209	209
query9	9404	2628	2622	2622
query10	484	244	234	234
query11	18046	15285	15255	15255
query12	154	106	98	98
query13	1568	431	415	415
query14	8942	7269	6619	6619
query15	232	183	188	183
query16	7918	479	477	477
query17	1438	588	575	575
query18	2095	299	310	299
query19	215	161	154	154
query20	121	115	115	115
query21	204	107	104	104
query22	4962	4565	4359	4359
query23	34850	34206	34310	34206
query24	10743	2731	2809	2731
query25	594	385	399	385
query26	725	155	163	155
query27	2092	277	277	277
query28	6613	2442	2422	2422
query29	763	409	417	409
query30	263	160	166	160
query31	1032	811	816	811
query32	91	55	55	55
query33	666	274	269	269
query34	896	515	498	498
query35	1007	868	881	868
query36	1101	948	944	944
query37	115	76	72	72
query38	4385	4244	4259	4244
query39	1468	1434	1406	1406
query40	197	97	98	97
query41	48	45	47	45
query42	105	95	96	95
query43	529	481	483	481
query44	1142	803	802	802
query45	180	164	164	164
query46	1134	693	693	693
query47	1959	1833	1871	1833
query48	418	335	320	320
query49	858	389	384	384
query50	792	377	402	377
query51	7243	6962	6961	6961
query52	100	86	88	86
query53	252	181	178	178
query54	1196	395	408	395
query55	76	75	77	75
query56	251	244	246	244
query57	1277	1157	1125	1125
query58	230	205	209	205
query59	3218	3252	3126	3126
query60	279	252	253	252
query61	117	119	123	119
query62	858	685	674	674
query63	209	180	186	180
query64	3791	611	630	611
query65	3294	3194	3144	3144
query66	807	297	323	297
query67	16206	15479	15620	15479
query68	4458	547	539	539
query69	425	254	264	254
query70	1184	1130	1145	1130
query71	343	260	247	247
query72	6319	3935	3996	3935
query73	764	357	352	352
query74	10157	8915	8954	8915
query75	3411	2647	2727	2647
query76	2364	1080	1042	1042
query77	378	264	261	261
query78	10440	9538	9489	9489
query79	1156	589	583	583
query80	962	417	405	405
query81	560	231	244	231
query82	1235	112	114	112
query83	232	138	138	138
query84	230	71	64	64
query85	1241	275	275	275
query86	403	289	292	289
query87	4816	4695	4600	4600
query88	3189	2199	2161	2161
query89	412	291	277	277
query90	1931	182	185	182
query91	131	97	100	97
query92	52	52	49	49
query93	1222	541	523	523
query94	860	274	290	274
query95	346	241	246	241
query96	609	285	301	285
query97	2847	2689	2685	2685
query98	216	202	194	194
query99	1553	1314	1292	1292
Total cold run time: 296590 ms
Total hot run time: 195888 ms

doris-robot · 2024-10-31T04:24:53Z

ClickBench: Total hot run time: 32.26 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fca28fe6280c78fdab828ec4e21c3ba92db5abb6, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.22	0.07	0.07
query4	1.65	0.11	0.10
query5	0.42	0.39	0.41
query6	1.15	0.66	0.65
query7	0.04	0.01	0.01
query8	0.03	0.03	0.03
query9	0.56	0.50	0.50
query10	0.56	0.55	0.55
query11	0.13	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.61	0.59
query14	2.79	2.88	2.92
query15	0.90	0.83	0.82
query16	0.39	0.38	0.39
query17	1.07	1.04	1.07
query18	0.20	0.20	0.20
query19	1.96	1.86	1.96
query20	0.01	0.00	0.01
query21	15.36	0.57	0.57
query22	2.59	2.26	1.20
query23	16.99	0.89	0.98
query24	2.43	0.98	1.48
query25	0.24	0.18	0.16
query26	0.34	0.14	0.13
query27	0.04	0.04	0.04
query28	10.83	1.09	1.07
query29	12.58	3.26	3.26
query30	0.25	0.06	0.06
query31	2.88	0.37	0.37
query32	3.30	0.45	0.46
query33	2.95	3.02	3.06
query34	17.17	4.48	4.45
query35	4.49	4.52	4.49
query36	0.68	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.03
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 106.52 s
Total hot run time: 32.26 s

fe/fe-core/src/main/java/org/apache/doris/alter/IndexChangeJob.java

github-actions · 2024-11-05T12:51:20Z

clang-tidy review says "All clean, LGTM! 👍"

qidaye · 2024-11-05T13:03:07Z

run buildall

airborne12

Add FE UT, just like SchemaChangeJobV2Test

be/src/common/status.h

fe/fe-core/src/main/java/org/apache/doris/alter/IndexChangeJob.java

airborne12 · 2024-11-07T01:22:30Z

run buildall

github-actions · 2024-11-07T01:27:03Z

clang-tidy review says "All clean, LGTM! 👍"

qidaye · 2024-11-07T08:58:40Z

run buildall

github-actions · 2024-11-07T09:02:57Z

clang-tidy review says "All clean, LGTM! 👍"

qidaye · 2024-11-07T09:03:25Z

Add FE UT, just like SchemaChangeJobV2Test

@airborne12 Added.

qidaye · 2024-11-07T11:43:08Z

run buildall

qidaye · 2024-11-07T14:13:53Z

run buildall

qidaye · 2024-11-07T14:14:44Z

run buildall

github-actions · 2024-11-07T14:18:10Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-11-07T14:18:45Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-11-07T15:59:56Z

TPC-H: Total hot run time: 41565 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 31531814ecee4e4b832c7e769a3de3b1a69a9b58, data reload: false

------ Round 1 ----------------------------------
q1	17635	7510	7288	7288
q2	2074	175	190	175
q3	10493	1150	1132	1132
q4	10240	826	823	823
q5	7758	3121	3106	3106
q6	235	150	149	149
q7	1020	613	598	598
q8	9383	1978	2102	1978
q9	6692	6446	6484	6446
q10	7045	2410	2429	2410
q11	473	260	260	260
q12	401	208	208	208
q13	17767	2979	2996	2979
q14	270	221	212	212
q15	588	544	511	511
q16	633	585	583	583
q17	984	531	531	531
q18	7530	6743	6761	6743
q19	1344	1031	1107	1031
q20	486	185	179	179
q21	4111	3218	3207	3207
q22	1140	1016	1029	1016
Total cold run time: 108302 ms
Total hot run time: 41565 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7285	7245	7243	7243
q2	347	258	244	244
q3	2939	2829	2794	2794
q4	1970	1734	1744	1734
q5	5518	5499	5483	5483
q6	217	135	140	135
q7	2168	1726	1734	1726
q8	3295	3449	3460	3449
q9	8630	8610	8634	8610
q10	3498	3463	3450	3450
q11	594	499	496	496
q12	783	593	584	584
q13	9611	3013	3004	3004
q14	313	265	276	265
q15	590	539	543	539
q16	667	637	635	635
q17	1822	1593	1590	1590
q18	7848	7442	7499	7442
q19	1682	1571	1609	1571
q20	2067	1808	1850	1808
q21	5408	5203	5291	5203
q22	1138	1053	1009	1009
Total cold run time: 68390 ms
Total hot run time: 59014 ms

doris-robot · 2024-11-07T16:10:28Z

TeamCity be ut coverage result:
Function Coverage: 37.88% (9850/26005)
Line Coverage: 29.04% (81940/282154)
Region Coverage: 28.27% (42211/149316)
Branch Coverage: 24.84% (21406/86186)
Coverage Report: http://coverage.selectdb-in.cc/coverage/31531814ecee4e4b832c7e769a3de3b1a69a9b58_31531814ecee4e4b832c7e769a3de3b1a69a9b58/report/index.html

doris-robot · 2024-11-07T16:12:08Z

TPC-DS: Total hot run time: 193707 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 31531814ecee4e4b832c7e769a3de3b1a69a9b58, data reload: false

query1	988	375	368	368
query2	6545	2116	2070	2070
query3	6786	215	218	215
query4	34412	23796	24033	23796
query5	4618	458	432	432
query6	278	182	174	174
query7	4604	300	291	291
query8	300	227	228	227
query9	9365	2757	2752	2752
query10	486	253	251	251
query11	18232	15291	15354	15291
query12	151	100	105	100
query13	1677	426	428	426
query14	10570	6670	7393	6670
query15	278	180	173	173
query16	8014	472	438	438
query17	1662	571	558	558
query18	2322	625	618	618
query19	391	172	179	172
query20	115	114	112	112
query21	209	102	102	102
query22	4714	4300	4302	4300
query23	35073	34753	36207	34753
query24	11709	3352	3212	3212
query25	569	401	401	401
query26	1040	182	187	182
query27	2674	280	289	280
query28	7953	2492	2465	2465
query29	669	437	427	427
query30	462	320	299	299
query31	1036	784	832	784
query32	97	58	59	58
query33	767	277	291	277
query34	946	511	515	511
query35	875	724	740	724
query36	1083	955	967	955
query37	118	76	70	70
query38	4414	4245	4271	4245
query39	1490	1431	1486	1431
query40	286	101	101	101
query41	50	48	48	48
query42	113	103	98	98
query43	533	481	485	481
query44	1270	834	831	831
query45	183	176	170	170
query46	1163	709	698	698
query47	1979	1832	1915	1832
query48	428	337	324	324
query49	1201	403	414	403
query50	806	390	401	390
query51	7326	7156	6986	6986
query52	102	88	88	88
query53	255	183	187	183
query54	1026	428	431	428
query55	82	77	79	77
query56	275	253	269	253
query57	1300	1194	1176	1176
query58	257	199	198	198
query59	3314	3022	3061	3022
query60	272	243	244	243
query61	112	113	109	109
query62	845	673	671	671
query63	216	188	183	183
query64	5469	651	625	625
query65	3313	3211	3228	3211
query66	1081	338	306	306
query67	16071	15806	15755	15755
query68	4902	597	612	597
query69	409	263	256	256
query70	1157	1092	1121	1092
query71	320	254	255	254
query72	6066	4048	4025	4025
query73	759	357	361	357
query74	10082	9087	8956	8956
query75	3465	2651	2664	2651
query76	2963	1073	1137	1073
query77	457	277	286	277
query78	10553	9479	9435	9435
query79	2276	621	624	621
query80	1161	430	423	423
query81	553	239	237	237
query82	942	118	123	118
query83	229	158	171	158
query84	231	68	70	68
query85	1208	305	297	297
query86	419	304	301	301
query87	4788	4673	4654	4654
query88	3573	2213	2170	2170
query89	402	291	295	291
query90	2038	188	186	186
query91	134	105	100	100
query92	60	54	54	54
query93	1791	573	555	555
query94	761	298	293	293
query95	344	243	248	243
query96	606	280	278	278
query97	2888	2680	2754	2680
query98	212	199	199	199
query99	1567	1308	1320	1308
Total cold run time: 304336 ms
Total hot run time: 193707 ms

qidaye · 2024-11-10T09:06:51Z

run buildall

github-actions · 2024-11-10T09:10:52Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-11-10T11:01:52Z

TeamCity be ut coverage result:
Function Coverage: 37.91% (9868/26027)
Line Coverage: 29.09% (82261/282777)
Region Coverage: 28.24% (42347/149928)
Branch Coverage: 24.79% (21442/86488)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ef4121ab124cbc73ee05b2c567a7ce1aab541908_ef4121ab124cbc73ee05b2c567a7ce1aab541908/report/index.html

qidaye · 2024-11-10T16:21:47Z

run performance

airborne12

LGTM

github-actions · 2024-11-11T06:06:40Z

PR approved by at least one committer and no changes requested.

eldenmoon

LGTM

…pache#42295) ## Proposed changes 1. Remove logic for replica majority failure checking 2. Introduce `OBTAIN_LOCK_FAILED` status code both in `status.h` and `Status.thrift` 3. Add `MIN_FAILED_NUM = 3` for non try_lock_failed failure task. The task will try 3 times before canceling the job. 4. Add `MAX_FAILED_NUM = 10` for try_lock_failed failure task. The task will try 10 times before canceling the job. --------- Co-authored-by: qidaye <[email protected]>

…pache#42295) 1. Remove logic for replica majority failure checking 2. Introduce `OBTAIN_LOCK_FAILED` status code both in `status.h` and `Status.thrift` 3. Add `MIN_FAILED_NUM = 3` for non try_lock_failed failure task. The task will try 3 times before canceling the job. 4. Add `MAX_FAILED_NUM = 10` for try_lock_failed failure task. The task will try 10 times before canceling the job. --------- Co-authored-by: qidaye <[email protected]>

…42295) (#43589) bp #42295 Co-authored-by: qidaye <[email protected]>

…42295) (#43581) bp #42295 Co-authored-by: qidaye <[email protected]>

airborne12 requested changes Oct 23, 2024

View reviewed changes

airborne12 reviewed Nov 1, 2024

View reviewed changes

fe/fe-core/src/main/java/org/apache/doris/alter/IndexChangeJob.java Outdated Show resolved Hide resolved

airborne12 reviewed Nov 5, 2024

View reviewed changes

xiaokang reviewed Nov 6, 2024

View reviewed changes

be/src/common/status.h Outdated Show resolved Hide resolved

fe/fe-core/src/main/java/org/apache/doris/alter/IndexChangeJob.java Show resolved Hide resolved

airborne12 force-pushed the opt_build_index_fail_check branch from de4bdee to 3f8ef95 Compare November 7, 2024 01:22

qidaye force-pushed the opt_build_index_fail_check branch from 3f8ef95 to 1aea2d8 Compare November 7, 2024 08:58

qidaye and others added 5 commits November 10, 2024 17:06

opt

dabdbb4

add ut

ae0d512

fix

cc180c0

format

b13d1f3

fix ut

ef4121a

qidaye force-pushed the opt_build_index_fail_check branch from 4ddb65f to ef4121a Compare November 10, 2024 09:06

airborne12 approved these changes Nov 11, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024

eldenmoon approved these changes Nov 11, 2024

View reviewed changes

qidaye merged commit 8e5a657 into apache:master Nov 11, 2024
25 of 28 checks passed

qidaye deleted the opt_build_index_fail_check branch November 11, 2024 06:12

qidaye added dev/2.1.x dev/3.0.x dev/2.0.x labels Nov 11, 2024

qidaye mentioned this pull request Nov 11, 2024

[improvement](build index)Optimize failed task check on same tablet (#42295) #43581

Merged

qidaye mentioned this pull request Nov 11, 2024

[improvement](build index)Optimize failed task check on same tablet (#42295) #43589

Merged

qidaye removed the dev/2.0.x label Nov 11, 2024

airborne12 pushed a commit that referenced this pull request Nov 12, 2024

[improvement](build index)Optimize failed task check on same tablet (#…

4c224bb

…42295) (#43589) bp #42295 Co-authored-by: qidaye <[email protected]>

wm1581066 added dev/2.1.8-merged and removed dev/2.1.x labels Nov 12, 2024

airborne12 pushed a commit that referenced this pull request Nov 12, 2024

[improvement](build index)Optimize failed task check on same tablet (#…

13b4c20

…42295) (#43581) bp #42295 Co-authored-by: qidaye <[email protected]>

airborne12 added dev/3.0.3-merged and removed dev/3.0.x labels Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[improvement](build index)Optimize failed task check on same tablet #42295

[improvement](build index)Optimize failed task check on same tablet #42295

qidaye commented Oct 22, 2024 •

edited

Loading

doris-robot commented Oct 22, 2024

qidaye commented Oct 22, 2024

doris-robot commented Oct 22, 2024

doris-robot commented Oct 22, 2024

doris-robot commented Oct 22, 2024

airborne12 left a comment

qidaye commented Oct 30, 2024

doris-robot commented Oct 31, 2024

doris-robot commented Oct 31, 2024

doris-robot commented Oct 31, 2024

github-actions bot commented Nov 5, 2024

qidaye commented Nov 5, 2024

airborne12 left a comment

airborne12 commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

qidaye commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

qidaye commented Nov 7, 2024

qidaye commented Nov 7, 2024

qidaye commented Nov 7, 2024

qidaye commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

doris-robot commented Nov 7, 2024

doris-robot commented Nov 7, 2024

doris-robot commented Nov 7, 2024

qidaye commented Nov 10, 2024

github-actions bot commented Nov 10, 2024

doris-robot commented Nov 10, 2024

qidaye commented Nov 10, 2024

airborne12 left a comment

github-actions bot commented Nov 11, 2024

eldenmoon left a comment

[improvement](build index)Optimize failed task check on same tablet #42295

[improvement](build index)Optimize failed task check on same tablet #42295

Conversation

qidaye commented Oct 22, 2024 • edited Loading

Proposed changes

doris-robot commented Oct 22, 2024

qidaye commented Oct 22, 2024

doris-robot commented Oct 22, 2024

doris-robot commented Oct 22, 2024

doris-robot commented Oct 22, 2024

airborne12 left a comment

Choose a reason for hiding this comment

qidaye commented Oct 30, 2024

doris-robot commented Oct 31, 2024

doris-robot commented Oct 31, 2024

doris-robot commented Oct 31, 2024

github-actions bot commented Nov 5, 2024

qidaye commented Nov 5, 2024

airborne12 left a comment

Choose a reason for hiding this comment

airborne12 commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

qidaye commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

qidaye commented Nov 7, 2024

qidaye commented Nov 7, 2024

qidaye commented Nov 7, 2024

qidaye commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

doris-robot commented Nov 7, 2024

doris-robot commented Nov 7, 2024

doris-robot commented Nov 7, 2024

qidaye commented Nov 10, 2024

github-actions bot commented Nov 10, 2024

doris-robot commented Nov 10, 2024

qidaye commented Nov 10, 2024

airborne12 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 11, 2024

eldenmoon left a comment

Choose a reason for hiding this comment

qidaye commented Oct 22, 2024 •

edited

Loading