Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](config) change segment_cache_fd_percentage and inverted_index_fd_number_limit_percent default value #42224

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[fix](config) change segment_cache_fd_percentage and inverted_index_fd_number_limit_percent default value #42224

merged 2 commits into from
Oct 24, 2024

Conversation

xiaokang
Copy link
Contributor

change segment_cache_fd_percentage and inverted_index_fd_number_limit_percent default value from 40% to 20% to avoid too many open files.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xiaokang
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9699/25891)
Line Coverage: 28.70% (80491/280472)
Region Coverage: 28.14% (41644/147990)
Branch Coverage: 24.71% (21161/85638)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a539c41c3aa3cfbf81e428d04f95fba5cf714603_a539c41c3aa3cfbf81e428d04f95fba5cf714603/report/index.html

airborne12
airborne12 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xiaokang
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9708/25910)
Line Coverage: 28.73% (80534/280271)
Region Coverage: 28.16% (41647/147884)
Branch Coverage: 24.72% (21154/85562)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f4c6714a0219bd573d89f7990d7e427e5d4a18e7_f4c6714a0219bd573d89f7990d7e427e5d4a18e7/report/index.html

dataroaring
dataroaring approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit afd9c09 into apache:master Oct 24, 2024
23 of 25 checks passed
@xiaokang xiaokang mentioned this pull request Oct 24, 2024
Merged
xiaokang added a commit to xiaokang/doris that referenced this pull request Oct 24, 2024
@xiaokang
[fix](config) change segment_cache_fd_percentage and inverted_index_f…
24b0e03 
…d_number_limit_percent default value (apache#42224)

change segment_cache_fd_percentage and
inverted_index_fd_number_limit_percent default value from 40% to 20% to
avoid too many open files.
@xiaokang xiaokang mentioned this pull request Oct 24, 2024
Merged
xiaokang added a commit to xiaokang/doris that referenced this pull request Oct 24, 2024
@xiaokang
[fix](config) change segment_cache_fd_percentage and inverted_index_f…
58a22bd 
…d_number_limit_percent default value (apache#42224)

change segment_cache_fd_percentage and
inverted_index_fd_number_limit_percent default value from 40% to 20% to
avoid too many open files.
@xiaokang xiaokang mentioned this pull request Oct 24, 2024
Merged
xiaokang added a commit to xiaokang/doris that referenced this pull request Oct 24, 2024
@xiaokang
[fix](config) change segment_cache_fd_percentage and inverted_index_f…
5bf5bb8 
…d_number_limit_percent default value (apache#42224)

change segment_cache_fd_percentage and
inverted_index_fd_number_limit_percent default value from 40% to 20% to
avoid too many open files.
xiaokang added a commit that referenced this pull request Oct 25, 2024
@xiaokang
[fix](config) change inverted_index_fd_number_limit_percent default v…
45608e7 
…alue #42224 (#42426)
xiaokang added a commit that referenced this pull request Oct 28, 2024
@xiaokang
[fix](config) change segment_cache_fd_percentage and inverted_index_f…
c387816 
…d_number_limit_percent default value #42224 (#42423)
xiaokang added a commit that referenced this pull request Oct 28, 2024
@xiaokang
[fix](config) change segment_cache_fd_percentage and inverted_index_f…
cea29ac 
…d_number_limit_percent default value #42224 (#42424)
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.16-merged dev/2.1.7-merged dev/3.0.3-merged p0_b reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaokang @doris-robot @airborne12 @dataroaring