Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature](cloud) Add cloud report for clean up expired tablets #42066

Merged
merged 5 commits into from
Nov 4, 2024
Merged

[Feature](cloud) Add cloud report for clean up expired tablets #42066

merged 5 commits into from
Nov 4, 2024

Conversation

deardeng
Copy link
Contributor

Proposed changes

  1. add tablet report to fe in cloud
  2. clean up expired tablet in be

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@deardeng deardeng marked this pull request as draft October 18, 2024 03:13
@deardeng
Copy link
Contributor Author

wait regression case

github-actions[bot]
github-actions bot reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/agent/task_worker_pool.cpp Show resolved Hide resolved
be/src/cloud/cloud_tablet_mgr.h Show resolved Hide resolved
@deardeng deardeng marked this pull request as ready for review October 22, 2024 15:00
@deardeng
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/agent/task_worker_pool.cpp Show resolved Hide resolved
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.45% (9706/25916)
Line Coverage: 28.71% (80512/280406)
Region Coverage: 28.14% (41625/147929)
Branch Coverage: 24.71% (21148/85588)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bf1dd9d524b3e4a56da7cd70ed30ca7c0f85e84f_bf1dd9d524b3e4a56da7cd70ed30ca7c0f85e84f/report/index.html

@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9709/25908)
Line Coverage: 28.72% (80504/280325)
Region Coverage: 28.16% (41640/147877)
Branch Coverage: 24.71% (21152/85588)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9a370cb2af6e370f26c8c94828aec6ddc179d9ff_9a370cb2af6e370f26c8c94828aec6ddc179d9ff/report/index.html

yujun777
yujun777 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

gavinchou
gavinchou requested changes Oct 24, 2024
View reviewed changes
be/src/cloud/cloud_tablet_mgr.h Outdated Show resolved Hide resolved
be/src/cloud/cloud_tablet_mgr.cpp Outdated Show resolved Hide resolved
be/src/cloud/cloud_tablet.h Outdated Show resolved Hide resolved
be/src/cloud/cloud_tablet_mgr.cpp Outdated Show resolved Hide resolved
be/src/cloud/cloud_tablet_mgr.cpp Show resolved Hide resolved
be/src/agent/task_worker_pool.cpp Show resolved Hide resolved
be/src/agent/task_worker_pool.cpp Outdated Show resolved Hide resolved
@deardeng deardeng force-pushed the cloud-report-tablet branch from 9a370cb to f49234c Compare October 28, 2024 08:38
@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.46% (9718/25943)
Line Coverage: 28.73% (80634/280621)
Region Coverage: 28.16% (41685/148046)
Branch Coverage: 24.71% (21173/85688)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f49234c345a523e9a168a91919fa4a865b8f7942_f49234c345a523e9a168a91919fa4a865b8f7942/report/index.html

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2024
@gavinchou gavinchou merged commit 9d45269 into apache:master Nov 4, 2024
25 of 27 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
@deardeng
[Feature](cloud) Add cloud report for clean up expired tablets (#42066)
b7f0047 
1. add tablet report to fe in cloud
2. clean up expired tablet in be
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 7, 2024
@github-actions @deardeng
branch-3.0: [Feature](cloud) Add cloud report for clean up expired ta…
5e4cf94 
…blets (#43233)

Cherry-picked from #42066

Co-authored-by: deardeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yujun777 yujun777 yujun777 approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deardeng @doris-robot @gavinchou @yujun777 @dataroaring