[Opt](orc-reader) Optimize orc reader by merging tiny stripes. #42062
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| DiskRange span(const DiskRange& other) const { | ||
| int64_t newOffset = std::min(offset, other.offset); | ||
| int64_t newEnd = std::max(getEnd(), other.getEnd()); | ||
| return DiskRange(newOffset, newEnd - newOffset); |
There was a problem hiding this comment.
warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
| return DiskRange(newOffset, newEnd - newOffset); | |
| return {newOffset, newEnd - newOffset}; |
| _size = _reader->size(); | ||
| } | ||
|
|
||
| ~CachingFileReader() override {} |
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
| ~CachingFileReader() override {} | |
| ~CachingFileReader() override = default; |
| RuntimeProfile* _profile = nullptr; | ||
| io::FileReaderSPtr _reader; | ||
| std::shared_ptr<RegionFinder> _region_finder; | ||
| int64_t _cache_position; |
There was a problem hiding this comment.
warning: use default member initializer for '_cache_position' [modernize-use-default-member-init]
be/src/io/fs/buffered_reader.h:593:
- _cache_position(0),
+ ,| int64_t _cache_position; | |
| int64_t _cache_position{0}; |
| io::FileReaderSPtr _reader; | ||
| std::shared_ptr<RegionFinder> _region_finder; | ||
| int64_t _cache_position; | ||
| int _cache_length; |
There was a problem hiding this comment.
warning: use default member initializer for '_cache_length' [modernize-use-default-member-init]
be/src/io/fs/buffered_reader.h:594:
- _cache_length(0),
+ ,| int _cache_length; | |
| int _cache_length{0}; |
|
|
||
| private: | ||
| std::vector<io::DiskRange> diskRanges; | ||
| size_t index; |
There was a problem hiding this comment.
warning: use default member initializer for 'index' [modernize-use-default-member-init]
be/src/vec/exec/format/orc/vorc_reader.h:693:
- )
+ )be/src/vec/exec/format/orc/vorc_reader.h:730:
- ;
+ {0};
Proposed changes
Issue Number: close #xxx