[regression test]Optimize waitForSchemeChangeDone #31002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
Vallishp
reviewed
Feb 8, 2024
| sql insertSql | ||
| } | ||
| if (cleanOperator==true){ | ||
| if (ObjectUtils.isEmpty(tbName)) throw new RuntimeException("tbName cloud not be null") |
There was a problem hiding this comment.
I think typing mistake : cloud ==> could
May be can we change it like "Table name must not be null"
There was a problem hiding this comment.
Good idea, I'll make some improvements
dataroaring
force-pushed
the
Opt_waitForSchemeChangeDone
branch
from
5fbe254 to
568b89a
Compare
|
run buildall |
Yukang-Lian
approved these changes
Feb 20, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
Feb 20, 2024
cjj2010
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...