Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) fix fe fold constant with date time out of range #45237

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

LiBinfeng-01
Copy link
Collaborator

@LiBinfeng-01 LiBinfeng-01 commented Dec 10, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

When running sql:
select date_add('9999-12-31 23:59:59', interval 5 second);
it should throw exception but not return null value

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40205 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3c4b7cdc3a4cc8b9c4c8be7318665a1ff43e4d18, data reload: false

------ Round 1 ----------------------------------
q1	17579	7538	7332	7332
q2	2045	176	174	174
q3	11065	1111	1232	1111
q4	10577	759	734	734
q5	7605	2727	2754	2727
q6	237	146	147	146
q7	998	668	611	611
q8	9233	1863	1949	1863
q9	6666	6441	6508	6441
q10	7049	2314	2292	2292
q11	464	267	265	265
q12	431	219	226	219
q13	17760	3045	3095	3045
q14	249	206	213	206
q15	592	549	525	525
q16	677	574	596	574
q17	999	600	515	515
q18	7157	6790	6650	6650
q19	1316	1090	1091	1090
q20	472	184	196	184
q21	4010	3190	3260	3190
q22	382	322	311	311
Total cold run time: 107563 ms
Total hot run time: 40205 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7284	7325	7291	7291
q2	328	234	231	231
q3	2946	2889	2991	2889
q4	2090	1838	1928	1838
q5	5696	5656	5675	5656
q6	227	142	142	142
q7	2224	1849	1797	1797
q8	3438	3564	3533	3533
q9	8914	9098	9039	9039
q10	3615	3575	3567	3567
q11	608	515	502	502
q12	860	627	588	588
q13	12108	3273	3324	3273
q14	309	265	275	265
q15	601	528	538	528
q16	693	651	651	651
q17	1871	1649	1618	1618
q18	8316	7687	7603	7603
q19	1689	1574	1627	1574
q20	2101	1870	1887	1870
q21	5712	5695	5563	5563
q22	667	621	577	577
Total cold run time: 72297 ms
Total hot run time: 60595 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197339 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3c4b7cdc3a4cc8b9c4c8be7318665a1ff43e4d18, data reload: false

query1	1258	960	945	945
query2	6267	2063	2019	2019
query3	11110	4639	4408	4408
query4	67004	28658	23513	23513
query5	4944	467	456	456
query6	408	188	174	174
query7	5462	313	297	297
query8	323	250	238	238
query9	8226	2737	2736	2736
query10	438	257	250	250
query11	17026	15415	15948	15415
query12	153	109	112	109
query13	1420	440	449	440
query14	11016	6952	7489	6952
query15	211	197	182	182
query16	7033	508	498	498
query17	1093	590	595	590
query18	1810	329	352	329
query19	199	155	148	148
query20	117	114	110	110
query21	197	104	102	102
query22	4778	4683	4324	4324
query23	35144	34264	34533	34264
query24	5683	2485	2512	2485
query25	481	388	377	377
query26	645	154	153	153
query27	2172	287	291	287
query28	4550	2532	2501	2501
query29	681	414	442	414
query30	211	148	148	148
query31	1011	896	849	849
query32	70	56	79	56
query33	416	295	300	295
query34	930	541	544	541
query35	874	776	769	769
query36	1109	953	966	953
query37	121	67	79	67
query38	4580	4498	4497	4497
query39	1501	1493	1481	1481
query40	200	101	97	97
query41	49	41	43	41
query42	109	96	101	96
query43	538	497	498	497
query44	1215	855	840	840
query45	195	179	175	175
query46	1164	707	728	707
query47	1979	1948	1882	1882
query48	434	337	347	337
query49	769	396	385	385
query50	845	401	398	398
query51	7314	7212	7094	7094
query52	98	86	88	86
query53	259	178	185	178
query54	508	401	404	401
query55	78	78	76	76
query56	255	259	248	248
query57	1228	1107	1133	1107
query58	235	212	207	207
query59	3147	3137	2941	2941
query60	265	245	248	245
query61	111	107	109	107
query62	800	669	678	669
query63	210	190	189	189
query64	1375	677	656	656
query65	3287	3227	3243	3227
query66	719	301	320	301
query67	15976	15645	15701	15645
query68	3932	580	578	578
query69	444	253	257	253
query70	1209	1166	1174	1166
query71	357	255	259	255
query72	6431	4172	4023	4023
query73	751	355	370	355
query74	10257	9005	9071	9005
query75	3389	2733	2670	2670
query76	1916	1042	1158	1042
query77	482	278	276	276
query78	10415	9440	9422	9422
query79	1532	593	597	593
query80	889	440	429	429
query81	495	237	233	233
query82	1312	120	126	120
query83	249	136	140	136
query84	282	73	72	72
query85	917	303	313	303
query86	338	301	310	301
query87	4660	4674	4518	4518
query88	3422	2215	2196	2196
query89	420	302	292	292
query90	2026	191	191	191
query91	137	105	110	105
query92	67	55	52	52
query93	1962	554	542	542
query94	788	292	291	291
query95	349	254	253	253
query96	631	282	277	277
query97	2981	2648	2670	2648
query98	214	198	201	198
query99	1618	1340	1341	1340
Total cold run time: 318906 ms
Total hot run time: 197339 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3c4b7cdc3a4cc8b9c4c8be7318665a1ff43e4d18, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.08	0.07
query4	1.62	0.11	0.12
query5	0.42	0.43	0.41
query6	1.14	0.66	0.66
query7	0.01	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.50	0.50
query10	0.55	0.54	0.54
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.62	0.61	0.60
query14	2.78	2.76	2.82
query15	0.92	0.83	0.82
query16	0.37	0.38	0.38
query17	1.08	1.02	1.07
query18	0.23	0.21	0.21
query19	1.97	1.86	2.03
query20	0.02	0.01	0.01
query21	15.36	0.58	0.58
query22	3.50	2.59	1.56
query23	17.24	0.91	0.78
query24	2.93	1.46	1.07
query25	0.29	0.17	0.11
query26	0.49	0.14	0.13
query27	0.04	0.04	0.03
query28	10.29	1.11	1.07
query29	12.54	3.29	3.27
query30	0.24	0.06	0.06
query31	2.87	0.39	0.39
query32	3.27	0.48	0.45
query33	3.06	2.99	3.04
query34	16.99	4.47	4.50
query35	4.58	4.50	4.54
query36	0.67	0.48	0.49
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.8 s
Total hot run time: 32.5 s

? new NullLiteral(DateTimeType.INSTANCE)
: new DateTimeLiteral(dateTime.getYear(), dateTime.getMonthValue(), dateTime.getDayOfMonth(),
if (isDateOutOfRange(dateTime)) {
throw new NotSupportedException("date out of range");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should print the detail message for user to debug

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

1 similar comment
@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32426 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 478f865ec61ba367b203286d7c108ce0d626a3d2, data reload: false

------ Round 1 ----------------------------------
q1	17589	6121	6007	6007
q2	2046	300	163	163
q3	10427	1247	704	704
q4	10214	843	435	435
q5	7524	2163	1951	1951
q6	208	183	144	144
q7	884	744	602	602
q8	9241	1328	1217	1217
q9	5232	4999	4916	4916
q10	6742	2304	1861	1861
q11	466	276	254	254
q12	345	357	215	215
q13	17757	3602	2907	2907
q14	239	229	211	211
q15	558	510	498	498
q16	637	622	590	590
q17	560	844	324	324
q18	7199	6464	6454	6454
q19	1483	974	545	545
q20	301	325	185	185
q21	2707	2209	1939	1939
q22	351	329	304	304
Total cold run time: 102710 ms
Total hot run time: 32426 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6261	6203	6165	6165
q2	235	320	234	234
q3	2252	2613	2349	2349
q4	1381	1818	1339	1339
q5	4327	4735	4730	4730
q6	181	179	140	140
q7	2093	1938	1819	1819
q8	2587	2738	2652	2652
q9	7334	7223	7189	7189
q10	3066	3330	2840	2840
q11	605	508	491	491
q12	672	729	599	599
q13	3367	3816	3089	3089
q14	272	303	269	269
q15	627	506	512	506
q16	622	681	632	632
q17	1203	1755	1240	1240
q18	7574	7345	7018	7018
q19	796	1050	1090	1050
q20	1895	1959	1817	1817
q21	5393	4959	4809	4809
q22	588	619	567	567
Total cold run time: 53331 ms
Total hot run time: 51544 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190717 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 478f865ec61ba367b203286d7c108ce0d626a3d2, data reload: false

query1	1001	370	374	370
query2	6523	2396	2331	2331
query3	6717	211	210	210
query4	34038	24150	23421	23421
query5	4377	627	463	463
query6	284	236	195	195
query7	4614	511	306	306
query8	314	275	230	230
query9	9543	2761	2763	2761
query10	467	307	244	244
query11	18738	15310	15023	15023
query12	166	114	106	106
query13	1683	542	417	417
query14	11466	8150	7195	7195
query15	250	196	186	186
query16	7796	641	454	454
query17	1623	756	583	583
query18	1258	369	337	337
query19	205	184	158	158
query20	122	113	110	110
query21	208	117	103	103
query22	4293	4585	4190	4190
query23	34981	33592	33532	33532
query24	6165	2275	2231	2231
query25	435	440	383	383
query26	768	239	149	149
query27	2046	461	320	320
query28	5407	2456	2436	2436
query29	525	508	410	410
query30	228	176	158	158
query31	986	904	823	823
query32	71	62	57	57
query33	514	341	286	286
query34	770	847	520	520
query35	786	839	725	725
query36	1012	1008	950	950
query37	111	103	72	72
query38	4276	4244	4248	4244
query39	1483	1579	1454	1454
query40	203	112	100	100
query41	46	44	46	44
query42	118	110	105	105
query43	497	509	491	491
query44	1272	798	811	798
query45	176	172	160	160
query46	881	1048	647	647
query47	1945	1911	1903	1903
query48	390	400	314	314
query49	722	480	386	386
query50	620	649	393	393
query51	7209	7106	7283	7106
query52	102	102	88	88
query53	228	247	183	183
query54	483	486	397	397
query55	78	79	97	79
query56	259	236	233	233
query57	1212	1178	1150	1150
query58	236	220	229	220
query59	3017	3080	3079	3079
query60	274	258	259	258
query61	112	110	120	110
query62	863	804	756	756
query63	224	190	181	181
query64	3418	997	642	642
query65	3304	3236	3210	3210
query66	917	418	308	308
query67	16102	15866	15674	15674
query68	9289	779	524	524
query69	469	291	249	249
query70	1272	1127	1122	1122
query71	441	285	254	254
query72	5772	3815	3831	3815
query73	688	770	364	364
query74	9853	9189	8892	8892
query75	4651	3147	2666	2666
query76	5427	1201	779	779
query77	1009	377	270	270
query78	10076	10296	9385	9385
query79	2918	932	618	618
query80	729	518	432	432
query81	467	280	238	238
query82	619	154	127	127
query83	160	167	146	146
query84	244	90	76	76
query85	873	373	300	300
query86	342	321	297	297
query87	4547	4394	4439	4394
query88	4553	2251	2243	2243
query89	415	347	306	306
query90	1922	190	188	188
query91	136	136	105	105
query92	66	53	63	53
query93	1286	893	550	550
query94	667	399	285	285
query95	337	261	252	252
query96	490	612	277	277
query97	2743	2829	2701	2701
query98	227	211	203	203
query99	1617	1568	1448	1448
Total cold run time: 295463 ms
Total hot run time: 190717 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.55 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 478f865ec61ba367b203286d7c108ce0d626a3d2, data reload: false

query1	0.05	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.08	0.06
query4	1.63	0.11	0.11
query5	0.42	0.41	0.41
query6	1.13	0.66	0.65
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.57	0.51	0.51
query10	0.55	0.57	0.58
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.61	0.60
query14	2.71	2.70	2.73
query15	0.89	0.82	0.83
query16	0.38	0.39	0.38
query17	1.04	1.02	1.06
query18	0.23	0.21	0.20
query19	1.99	1.87	2.03
query20	0.01	0.01	0.01
query21	15.36	0.90	0.58
query22	0.74	0.70	0.83
query23	15.31	1.40	0.51
query24	3.16	1.21	1.45
query25	0.20	0.21	0.05
query26	0.19	0.16	0.14
query27	0.05	0.08	0.05
query28	13.82	1.50	1.04
query29	12.59	3.90	3.28
query30	0.25	0.09	0.06
query31	2.84	0.58	0.37
query32	3.22	0.56	0.45
query33	3.19	3.12	3.11
query34	16.92	5.14	4.49
query35	4.55	4.51	4.53
query36	0.63	0.50	0.47
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.35 s
Total hot run time: 31.55 s

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32789 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1dbdfef4bf1ae278a07de8c72a390b5ceb3a2eff, data reload: false

------ Round 1 ----------------------------------
q1	17589	6127	6041	6041
q2	2034	305	178	178
q3	10421	1226	759	759
q4	10237	858	427	427
q5	8134	2168	1999	1999
q6	205	181	148	148
q7	896	756	623	623
q8	9251	1377	1185	1185
q9	5101	4846	4998	4846
q10	6771	2315	1854	1854
q11	486	289	271	271
q12	358	358	220	220
q13	17915	3618	3066	3066
q14	233	235	233	233
q15	564	489	496	489
q16	618	618	583	583
q17	609	879	338	338
q18	6980	6495	6356	6356
q19	2042	977	590	590
q20	310	314	185	185
q21	3064	2327	2084	2084
q22	378	347	314	314
Total cold run time: 104196 ms
Total hot run time: 32789 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6309	6211	6263	6211
q2	239	337	229	229
q3	2218	2650	2322	2322
q4	1425	1878	1426	1426
q5	4339	4785	4868	4785
q6	193	185	146	146
q7	2055	1971	1837	1837
q8	2664	2783	2715	2715
q9	7353	7293	7299	7293
q10	3066	3380	2754	2754
q11	578	510	489	489
q12	662	780	630	630
q13	3332	3786	3151	3151
q14	293	314	274	274
q15	591	522	502	502
q16	661	709	647	647
q17	1241	1726	1286	1286
q18	7671	7555	7385	7385
q19	882	1197	1102	1102
q20	1998	2000	1949	1949
q21	5774	5345	4855	4855
q22	642	629	626	626
Total cold run time: 54186 ms
Total hot run time: 52614 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196450 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1dbdfef4bf1ae278a07de8c72a390b5ceb3a2eff, data reload: false

query1	1276	925	921	921
query2	6485	2271	2254	2254
query3	11000	4903	4456	4456
query4	33562	24180	23531	23531
query5	4639	615	459	459
query6	296	218	170	170
query7	3982	485	303	303
query8	293	232	221	221
query9	9518	2736	2724	2724
query10	477	300	245	245
query11	18226	15545	15220	15220
query12	159	105	104	104
query13	1558	550	380	380
query14	10584	7073	7356	7073
query15	253	218	193	193
query16	8068	603	464	464
query17	1499	760	593	593
query18	2145	410	308	308
query19	215	176	160	160
query20	117	113	115	113
query21	207	124	108	108
query22	4467	4514	4292	4292
query23	34976	34383	33712	33712
query24	6765	2371	2370	2370
query25	449	454	382	382
query26	764	250	150	150
query27	2410	471	332	332
query28	5410	2503	2522	2503
query29	547	529	423	423
query30	210	188	152	152
query31	994	932	851	851
query32	77	60	57	57
query33	473	349	294	294
query34	759	868	525	525
query35	806	829	760	760
query36	1023	1069	958	958
query37	123	95	83	83
query38	4513	4262	4097	4097
query39	1522	1443	1461	1443
query40	211	116	101	101
query41	46	43	45	43
query42	127	112	109	109
query43	518	527	498	498
query44	1354	879	813	813
query45	196	167	170	167
query46	898	1078	672	672
query47	2006	2033	1912	1912
query48	385	427	331	331
query49	737	483	387	387
query50	635	692	401	401
query51	7210	7271	7200	7200
query52	107	97	91	91
query53	232	262	187	187
query54	488	497	435	435
query55	85	79	74	74
query56	260	306	265	265
query57	1259	1226	1170	1170
query58	233	234	220	220
query59	3104	3265	3134	3134
query60	279	278	262	262
query61	107	111	110	110
query62	872	815	769	769
query63	233	192	189	189
query64	3420	1038	699	699
query65	3320	3270	3308	3270
query66	772	399	318	318
query67	16369	15707	15489	15489
query68	7933	765	543	543
query69	477	285	249	249
query70	1192	1150	1124	1124
query71	410	291	277	277
query72	6086	3996	3996	3996
query73	663	855	359	359
query74	10290	9039	9188	9039
query75	3475	3156	2651	2651
query76	3338	1191	777	777
query77	636	361	292	292
query78	11002	10250	9393	9393
query79	5488	844	593	593
query80	849	518	414	414
query81	520	263	234	234
query82	673	159	125	125
query83	196	164	149	149
query84	280	97	68	68
query85	784	350	299	299
query86	392	318	294	294
query87	4494	4599	4332	4332
query88	5204	2229	2213	2213
query89	433	317	295	295
query90	1917	191	185	185
query91	136	144	105	105
query92	68	52	53	52
query93	2708	802	540	540
query94	701	386	271	271
query95	336	263	252	252
query96	499	609	293	293
query97	2810	2858	2699	2699
query98	226	202	199	199
query99	1683	1557	1438	1438
Total cold run time: 302209 ms
Total hot run time: 196450 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1dbdfef4bf1ae278a07de8c72a390b5ceb3a2eff, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.03	0.04
query3	0.23	0.07	0.08
query4	1.60	0.10	0.10
query5	0.42	0.42	0.42
query6	1.16	0.65	0.65
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.60	0.51	0.50
query10	0.55	0.59	0.55
query11	0.15	0.10	0.10
query12	0.13	0.12	0.11
query13	0.60	0.61	0.59
query14	2.83	2.86	2.73
query15	0.90	0.84	0.83
query16	0.37	0.37	0.37
query17	1.01	1.04	1.08
query18	0.22	0.20	0.21
query19	1.95	1.89	1.93
query20	0.02	0.01	0.01
query21	15.36	0.88	0.58
query22	0.76	0.81	0.73
query23	15.25	1.39	0.53
query24	3.39	1.29	1.59
query25	0.13	0.12	0.15
query26	0.32	0.15	0.14
query27	0.05	0.05	0.05
query28	14.06	1.51	1.04
query29	12.55	3.97	3.27
query30	0.24	0.09	0.08
query31	2.82	0.59	0.38
query32	3.27	0.55	0.46
query33	3.06	3.09	3.12
query34	16.90	5.06	4.49
query35	4.53	4.47	4.47
query36	0.65	0.49	0.47
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.73 s
Total hot run time: 31.77 s

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32530 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08ee80d49976ce5a7f54071346e04c1a861bd3ba, data reload: false

------ Round 1 ----------------------------------
q1	17614	6178	6068	6068
q2	2045	289	182	182
q3	10418	1244	715	715
q4	10200	862	420	420
q5	7507	2156	1960	1960
q6	207	182	147	147
q7	904	775	617	617
q8	9228	1325	1117	1117
q9	5212	4867	4941	4867
q10	6759	2324	1867	1867
q11	489	283	262	262
q12	351	371	217	217
q13	17756	3559	2979	2979
q14	232	234	216	216
q15	558	496	493	493
q16	618	608	603	603
q17	559	834	324	324
q18	7025	6476	6455	6455
q19	1225	954	560	560
q20	305	308	186	186
q21	2890	2180	1971	1971
q22	361	330	304	304
Total cold run time: 102463 ms
Total hot run time: 32530 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6238	6205	6216	6205
q2	231	327	228	228
q3	2227	2622	2336	2336
q4	1409	1815	1359	1359
q5	4340	4736	4668	4668
q6	186	178	146	146
q7	2068	1974	1816	1816
q8	2567	2775	2699	2699
q9	7301	7228	7135	7135
q10	3094	3349	2836	2836
q11	584	521	509	509
q12	633	750	624	624
q13	3331	3734	3064	3064
q14	292	317	274	274
q15	584	508	515	508
q16	666	693	619	619
q17	1213	1763	1253	1253
q18	7698	7252	7235	7235
q19	805	1089	1024	1024
q20	1943	1953	1828	1828
q21	5570	5117	4816	4816
q22	616	639	561	561
Total cold run time: 53596 ms
Total hot run time: 51743 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191352 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08ee80d49976ce5a7f54071346e04c1a861bd3ba, data reload: false

query1	996	367	377	367
query2	6526	2359	2376	2359
query3	6705	212	207	207
query4	33995	23914	23542	23542
query5	4856	622	464	464
query6	300	197	188	188
query7	4622	492	311	311
query8	306	245	243	243
query9	9290	2755	2759	2755
query10	492	309	254	254
query11	18282	15619	15713	15619
query12	168	110	105	105
query13	1681	542	411	411
query14	10967	7880	7403	7403
query15	287	201	187	187
query16	7957	645	490	490
query17	1610	744	588	588
query18	1820	382	319	319
query19	204	177	147	147
query20	117	117	110	110
query21	210	119	105	105
query22	4319	4343	4211	4211
query23	35347	33646	33870	33646
query24	6321	2281	2246	2246
query25	453	453	381	381
query26	1070	247	149	149
query27	2012	456	322	322
query28	5202	2454	2426	2426
query29	517	519	405	405
query30	227	209	149	149
query31	1011	900	826	826
query32	75	62	61	61
query33	526	332	289	289
query34	759	843	524	524
query35	783	840	752	752
query36	1017	1072	971	971
query37	116	99	76	76
query38	4107	4079	4261	4079
query39	1496	1447	1443	1443
query40	198	117	97	97
query41	46	44	45	44
query42	118	102	101	101
query43	513	509	491	491
query44	1292	810	820	810
query45	181	177	160	160
query46	871	1040	641	641
query47	1898	1921	1847	1847
query48	382	401	315	315
query49	768	500	386	386
query50	614	667	384	384
query51	7001	7198	7156	7156
query52	106	101	90	90
query53	229	253	185	185
query54	481	484	399	399
query55	81	74	77	74
query56	279	262	238	238
query57	1173	1186	1133	1133
query58	233	223	224	223
query59	3049	2998	3045	2998
query60	291	264	246	246
query61	107	105	111	105
query62	852	802	731	731
query63	220	187	183	183
query64	3980	1013	641	641
query65	3276	3184	3274	3184
query66	833	489	314	314
query67	15954	15915	15622	15622
query68	9566	754	524	524
query69	464	285	248	248
query70	1259	1142	1091	1091
query71	445	284	260	260
query72	5701	3888	3856	3856
query73	741	749	376	376
query74	10063	9152	8848	8848
query75	4628	3122	2658	2658
query76	5652	1190	770	770
query77	1030	370	268	268
query78	10200	10285	9376	9376
query79	3787	915	579	579
query80	712	512	422	422
query81	475	284	235	235
query82	487	159	123	123
query83	197	160	144	144
query84	279	91	72	72
query85	751	349	297	297
query86	354	299	312	299
query87	4542	4569	4432	4432
query88	3326	2243	2179	2179
query89	444	331	298	298
query90	2118	183	183	183
query91	130	132	104	104
query92	69	55	53	53
query93	1862	888	539	539
query94	679	403	284	284
query95	321	257	243	243
query96	484	610	272	272
query97	2737	2803	2736	2736
query98	224	200	197	197
query99	1674	1549	1458	1458
Total cold run time: 297176 ms
Total hot run time: 191352 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 08ee80d49976ce5a7f54071346e04c1a861bd3ba, data reload: false

query1	0.04	0.04	0.06
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.42	0.38	0.42
query6	1.17	0.66	0.64
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.58	0.50	0.50
query10	0.56	0.58	0.56
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.61
query14	2.71	2.72	2.69
query15	0.89	0.82	0.83
query16	0.38	0.39	0.39
query17	0.98	1.07	1.03
query18	0.23	0.21	0.22
query19	1.89	1.85	2.00
query20	0.01	0.01	0.01
query21	15.36	0.92	0.59
query22	0.76	0.82	0.63
query23	15.31	1.33	0.53
query24	3.04	1.00	1.50
query25	0.21	0.06	0.13
query26	0.40	0.15	0.14
query27	0.08	0.05	0.04
query28	13.82	1.49	1.05
query29	12.55	3.98	3.28
query30	0.25	0.10	0.07
query31	2.82	0.61	0.40
query32	3.23	0.55	0.47
query33	3.10	3.13	3.13
query34	16.84	5.13	4.54
query35	4.56	4.49	4.51
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.14
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.2 s
Total hot run time: 31.39 s

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32178 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08ee80d49976ce5a7f54071346e04c1a861bd3ba, data reload: false

------ Round 1 ----------------------------------
q1	17572	6091	5981	5981
q2	2051	295	165	165
q3	10455	1230	746	746
q4	10246	865	425	425
q5	8297	2190	1960	1960
q6	207	184	148	148
q7	895	755	603	603
q8	9235	1345	1136	1136
q9	5244	4896	5010	4896
q10	6828	2307	1861	1861
q11	465	276	246	246
q12	341	356	216	216
q13	17778	3542	2907	2907
q14	230	229	217	217
q15	552	507	511	507
q16	614	619	574	574
q17	545	847	319	319
q18	6792	6392	6273	6273
q19	1743	966	532	532
q20	298	313	182	182
q21	2785	2126	1974	1974
q22	360	342	310	310
Total cold run time: 103533 ms
Total hot run time: 32178 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6276	6238	6187	6187
q2	231	328	233	233
q3	2260	2662	2307	2307
q4	1369	1813	1342	1342
q5	4290	4725	4722	4722
q6	182	173	142	142
q7	2059	1910	1816	1816
q8	2613	2842	2656	2656
q9	7360	7270	7269	7269
q10	3065	3369	2832	2832
q11	596	501	488	488
q12	625	733	602	602
q13	3397	3773	3131	3131
q14	300	304	266	266
q15	579	518	509	509
q16	647	679	643	643
q17	1203	1719	1264	1264
q18	7655	7399	7264	7264
q19	807	1105	1085	1085
q20	2020	2061	1901	1901
q21	5633	5305	4861	4861
q22	590	617	582	582
Total cold run time: 53757 ms
Total hot run time: 52102 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196652 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08ee80d49976ce5a7f54071346e04c1a861bd3ba, data reload: false

query1	1283	954	933	933
query2	6485	2429	2357	2357
query3	10954	4585	4527	4527
query4	33105	23699	23436	23436
query5	3759	603	459	459
query6	288	198	208	198
query7	3984	476	295	295
query8	285	244	222	222
query9	9294	2735	2717	2717
query10	450	316	249	249
query11	17922	16093	15205	15205
query12	169	108	104	104
query13	1607	536	408	408
query14	11799	6873	7972	6873
query15	253	206	198	198
query16	8046	636	472	472
query17	1523	798	609	609
query18	2124	432	330	330
query19	202	193	177	177
query20	134	120	111	111
query21	208	126	109	109
query22	4832	4800	4613	4613
query23	34262	33162	33254	33162
query24	6367	2263	2350	2263
query25	520	445	396	396
query26	778	274	151	151
query27	2001	480	327	327
query28	5626	2514	2490	2490
query29	643	575	429	429
query30	202	198	151	151
query31	1024	907	848	848
query32	78	57	62	57
query33	477	351	294	294
query34	757	865	536	536
query35	791	842	748	748
query36	1037	1097	965	965
query37	116	100	73	73
query38	4325	4384	4118	4118
query39	1507	1455	1487	1455
query40	208	122	101	101
query41	46	45	43	43
query42	121	102	108	102
query43	543	547	511	511
query44	1353	811	822	811
query45	177	170	175	170
query46	864	1063	660	660
query47	2027	1997	1955	1955
query48	384	425	328	328
query49	712	476	413	413
query50	650	671	404	404
query51	7323	7198	7191	7191
query52	102	102	97	97
query53	230	264	196	196
query54	492	482	431	431
query55	86	80	82	80
query56	271	256	253	253
query57	1255	1248	1154	1154
query58	249	242	228	228
query59	3317	3517	3207	3207
query60	269	272	251	251
query61	108	102	109	102
query62	852	829	756	756
query63	237	193	189	189
query64	3480	1012	649	649
query65	3323	3278	3309	3278
query66	707	410	319	319
query67	16215	15855	15587	15587
query68	9468	748	513	513
query69	482	309	261	261
query70	1245	1133	1107	1107
query71	442	287	257	257
query72	6221	3854	3799	3799
query73	659	746	371	371
query74	10576	9288	8879	8879
query75	4540	3153	2648	2648
query76	5125	1300	780	780
query77	964	370	281	281
query78	10031	10276	10101	10101
query79	4986	865	575	575
query80	722	511	426	426
query81	505	275	228	228
query82	503	148	123	123
query83	199	158	143	143
query84	278	91	72	72
query85	748	399	314	314
query86	344	318	312	312
query87	4632	4423	4479	4423
query88	3835	2225	2190	2190
query89	434	331	297	297
query90	2089	189	189	189
query91	135	136	104	104
query92	67	53	52	52
query93	2357	878	515	515
query94	654	379	289	289
query95	333	261	246	246
query96	485	613	286	286
query97	2733	2788	2664	2664
query98	216	199	191	191
query99	1652	1543	1485	1485
Total cold run time: 302478 ms
Total hot run time: 196652 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.4 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 08ee80d49976ce5a7f54071346e04c1a861bd3ba, data reload: false

query1	0.06	0.04	0.03
query2	0.07	0.03	0.04
query3	0.24	0.08	0.07
query4	1.60	0.10	0.10
query5	0.45	0.43	0.41
query6	1.15	0.65	0.66
query7	0.02	0.01	0.02
query8	0.03	0.03	0.03
query9	0.59	0.50	0.50
query10	0.55	0.58	0.56
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.61
query14	2.71	2.85	2.75
query15	0.89	0.83	0.82
query16	0.38	0.37	0.39
query17	1.07	1.02	1.04
query18	0.22	0.21	0.21
query19	1.87	1.74	2.04
query20	0.01	0.01	0.01
query21	15.36	0.92	0.59
query22	0.75	0.82	0.65
query23	15.26	1.41	0.57
query24	2.93	1.61	1.07
query25	0.22	0.21	0.20
query26	0.23	0.15	0.13
query27	0.08	0.04	0.06
query28	14.25	1.51	1.04
query29	12.56	3.97	3.25
query30	0.25	0.09	0.06
query31	2.82	0.59	0.38
query32	3.22	0.54	0.46
query33	3.06	3.10	3.14
query34	16.78	5.14	4.50
query35	4.46	4.46	4.48
query36	0.66	0.49	0.49
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.14	0.13
query41	0.07	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.19 s
Total hot run time: 31.4 s

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32313 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08ee80d49976ce5a7f54071346e04c1a861bd3ba, data reload: false

------ Round 1 ----------------------------------
q1	17630	6119	5968	5968
q2	2039	299	166	166
q3	10419	1237	707	707
q4	10210	849	439	439
q5	7515	2147	1956	1956
q6	207	181	146	146
q7	887	748	597	597
q8	9227	1347	1112	1112
q9	5173	4983	5025	4983
q10	6768	2314	1853	1853
q11	477	281	264	264
q12	344	355	212	212
q13	17802	3505	2925	2925
q14	244	224	220	220
q15	554	503	516	503
q16	638	614	585	585
q17	558	840	318	318
q18	7186	6353	6503	6353
q19	1225	956	535	535
q20	307	327	192	192
q21	2942	2225	1960	1960
q22	362	342	319	319
Total cold run time: 102714 ms
Total hot run time: 32313 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6227	6245	6200	6200
q2	237	320	232	232
q3	2245	2659	2355	2355
q4	1442	1837	1379	1379
q5	4342	4747	4673	4673
q6	182	181	142	142
q7	2119	1957	1827	1827
q8	2595	2740	2650	2650
q9	7267	7260	7136	7136
q10	3035	3335	2796	2796
q11	585	507	499	499
q12	658	750	602	602
q13	3255	3710	3078	3078
q14	292	296	266	266
q15	578	513	498	498
q16	665	688	650	650
q17	1194	1718	1228	1228
q18	7715	7420	7133	7133
q19	774	1085	1016	1016
q20	1862	2007	1787	1787
q21	5436	5032	4880	4880
q22	609	619	604	604
Total cold run time: 53314 ms
Total hot run time: 51631 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191269 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08ee80d49976ce5a7f54071346e04c1a861bd3ba, data reload: false

query1	971	401	389	389
query2	6528	2394	2392	2392
query3	6707	214	214	214
query4	34048	23676	23632	23632
query5	4358	620	456	456
query6	281	194	201	194
query7	4632	482	303	303
query8	304	247	242	242
query9	9318	2743	2742	2742
query10	478	324	268	268
query11	18001	15401	15433	15401
query12	163	116	107	107
query13	1685	549	411	411
query14	10099	7332	7336	7332
query15	249	194	186	186
query16	7554	591	452	452
query17	1580	754	573	573
query18	1341	411	297	297
query19	229	178	150	150
query20	117	108	110	108
query21	206	120	100	100
query22	4424	4657	4596	4596
query23	34477	33479	33342	33342
query24	6352	2210	2254	2210
query25	475	441	369	369
query26	906	277	148	148
query27	1977	452	344	344
query28	5292	2475	2452	2452
query29	600	522	399	399
query30	228	180	146	146
query31	1006	910	784	784
query32	68	57	60	57
query33	512	389	274	274
query34	734	826	510	510
query35	816	801	732	732
query36	1004	1033	926	926
query37	118	96	78	78
query38	4233	4092	4071	4071
query39	1490	1447	1433	1433
query40	209	115	106	106
query41	46	47	50	47
query42	116	102	101	101
query43	523	542	487	487
query44	1248	788	789	788
query45	181	173	164	164
query46	850	1036	638	638
query47	1921	1938	1921	1921
query48	391	420	314	314
query49	760	487	394	394
query50	613	646	390	390
query51	7156	7303	7191	7191
query52	97	99	92	92
query53	230	248	181	181
query54	468	475	414	414
query55	78	78	79	78
query56	264	250	242	242
query57	1198	1175	1130	1130
query58	225	222	222	222
query59	3060	3491	3104	3104
query60	262	261	249	249
query61	116	105	108	105
query62	888	789	745	745
query63	225	189	190	189
query64	3742	985	628	628
query65	3252	3175	3234	3175
query66	959	413	302	302
query67	16050	15884	15669	15669
query68	9181	730	504	504
query69	497	284	255	255
query70	1260	1047	1137	1047
query71	441	276	261	261
query72	5751	3793	3887	3793
query73	659	739	361	361
query74	10382	9001	8827	8827
query75	4650	3179	2669	2669
query76	5537	1164	795	795
query77	1001	353	280	280
query78	10111	10230	9404	9404
query79	4373	885	584	584
query80	674	511	428	428
query81	473	259	221	221
query82	221	157	121	121
query83	200	163	154	154
query84	278	98	71	71
query85	752	354	298	298
query86	349	315	311	311
query87	4591	4507	4576	4507
query88	3788	2236	2210	2210
query89	479	347	296	296
query90	2082	190	185	185
query91	136	141	109	109
query92	71	56	53	53
query93	2898	887	516	516
query94	664	394	289	289
query95	339	260	250	250
query96	492	604	279	279
query97	2698	2775	2684	2684
query98	223	198	204	198
query99	1655	1515	1423	1423
Total cold run time: 295595 ms
Total hot run time: 191269 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.85 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 08ee80d49976ce5a7f54071346e04c1a861bd3ba, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.08	0.07
query4	1.61	0.10	0.11
query5	0.42	0.41	0.42
query6	1.14	0.66	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.59	0.52	0.50
query10	0.55	0.55	0.55
query11	0.14	0.11	0.11
query12	0.13	0.12	0.11
query13	0.59	0.60	0.60
query14	2.85	2.74	2.83
query15	0.89	0.82	0.83
query16	0.38	0.39	0.37
query17	0.98	1.07	1.00
query18	0.22	0.21	0.21
query19	1.85	1.89	1.98
query20	0.01	0.01	0.01
query21	15.35	0.94	0.60
query22	0.76	0.85	0.64
query23	15.24	1.47	0.60
query24	3.09	1.59	0.35
query25	0.22	0.11	0.13
query26	0.31	0.15	0.14
query27	0.07	0.04	0.06
query28	13.53	1.56	1.04
query29	12.55	3.97	3.23
query30	0.25	0.08	0.08
query31	2.81	0.61	0.39
query32	3.22	0.54	0.45
query33	3.11	3.19	3.07
query34	16.79	5.32	4.53
query35	4.54	4.53	4.55
query36	0.63	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.13	0.12
query41	0.07	0.04	0.03
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.71 s
Total hot run time: 30.85 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 27, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@englefly
Copy link
Contributor

return null 才是正确的返回方式
类比 除以0的情况

@zclllyybb
Copy link
Contributor

return null 才是正确的返回方式 类比 除以0的情况

可能恰恰相反啊。。有些return null的,我们反而要逐渐改到报错去

@englefly englefly merged commit d5d4248 into apache:master Dec 27, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants