Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5G detection #125

Open
ath0mas opened this issue Oct 18, 2020 · 13 comments · May be fixed by #130
Open

5G detection #125

ath0mas opened this issue Oct 18, 2020 · 13 comments · May be fixed by #130

Comments

@ath0mas
Copy link

ath0mas commented Oct 18, 2020

Feature Request

Motivation Behind Feature

5G connectivity starts to be available on modern Android and iOS devices: since Android 11 and iOS 14/iPhone 12.

Feature Description

Detect 5G network and return 5g, from new value CELL_5G: '5g' to be added in Connection.js exports.

Alternatives or Workarounds

Don't know.

@timbru31
Copy link
Member

PR's welcome!

@paulieo10
Copy link

paulieo10 commented May 10, 2021

Has there been any progress with this issue? I'd say being able to detect 5g is quite important. Does anyone know how the plugin behaves a the moment when a device is connected to 5g? Will it return UNKNOWN?

@ZumelzuR
Copy link

Has there been any progress with this issue? I'd say being able to detect 5g is quite important. Does anyone know how the plugin behaves a the moment when a device is connected to 5g? Will it return UNKNOWN?

I will do a PR with the improvements for 5g. I already tested with android but I still some time for ios.

@ZumelzuR
Copy link

#130

@breautek breautek linked a pull request Oct 14, 2021 that will close this issue
@cels
Copy link

cels commented Apr 7, 2022

Is there anything new on this problem? The PR is open for almost a year 🤔

@ZumelzuR
Copy link

ZumelzuR commented Apr 7, 2022

Sorry was impossible for me to do the fixes they required for the MR. I did it today so hope they approve :D

@cels
Copy link

cels commented Apr 12, 2022

Thanks a lot!

@cels
Copy link

cels commented Jul 29, 2022

Anything new here? Is there a plan when this will be merged?

@mdivya-symplr
Copy link

@ZumelzuR Any plan for this code merge? or Are there any alternative to this?

@breautek
Copy link
Contributor

breautek commented Oct 3, 2022

@ZumelzuR Any plan for this code merge? or Are there any alternative to this?

He doesn't have write access to the repository, only Apache members can merge it in.

Looking at the PR it looks like it's marked as a breaking change, so it won't be merged in until we prepare the main branch as a major release. Right now it's prepared as a patch release.

Additionally it only has 1 approved review, and usually we like to see at least 2 approved reviews from Apache members. Others are also welcome to review/test the PR.

@ZumelzuR
Copy link

ZumelzuR commented Oct 5, 2022

I dont know how to fix the ios12 test fail, if someone can lead me on this I could try to fix what is missing to be approved. Anyway for the moment feel free to use my fork https://github.com/ZumelzuR/cordova-plugin-network-information

@BigBalli
Copy link

Happy to help but the logs for this run have expired and are no longer available.

@ZumelzuR
Copy link

Happy to help but the logs for this run have expired and are no longer available.

Same here, how we can run this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants