Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5G detect support #145

Closed
ghost opened this issue Feb 22, 2022 · 4 comments
Closed

5G detect support #145

ghost opened this issue Feb 22, 2022 · 4 comments

Comments

@ghost
Copy link

ghost commented Feb 22, 2022

Feature Request

Motivation Behind Feature

Recently, a lot of device support 5G celluar. and some people need 5g support in this lib.

Feature Description

if connected network celluar is 5G, navigator.connection.type return '5G'.

Alternatives or Workarounds

nope.

I already know, this feature discuss in issues.
Is there any plan update this lib version what 5g detect feature attached?

@breautek
Copy link
Contributor

breautek commented Feb 22, 2022

The main issue with #130 is that the PR is changing things that shouldn't be changed and the PR author hasn't taken the time to make those corrections unfortunately. As a result, the PR cannot be merged in it's current state.

Another PR can be created to add 5G detection support to supersede that existing PR.

Closing as duplicate feature request: #125

@ghost
Copy link
Author

ghost commented Feb 22, 2022

@breautek Is there any plan update this feature?
If answer is 'yes', when this feature update?

@breautek
Copy link
Contributor

Yes it is planned, but "when" I cannot say due to the volunteer nature of Apache projects. It's whenever someone decides to volunteer their time in preparing a pull request.

@ghost
Copy link
Author

ghost commented Feb 22, 2022

@breautek Thanks for your answer! your answer gave me a lot of help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant