[WIP] use relative path for template, to avoid git failure #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodycj
commented
Jun 24, 2020
| @@ -420,7 +420,7 @@ if (argv.plugman) { | |||
| // Create the project using "cordova create" | |||
| myDelete(cli_project_dir); | |||
| console.log("### Creating project mobilespec..."); | |||
| executeShellCommand(cli + " create " + projectDirName + " org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" + path.sep + "www"); | |||
| executeShellCommand(cli + " create " + projectDirName + " org.apache.cordova.mobilespec MobileSpec_Tests --template ./cordova-mobile-spec" + path.sep + "www"); | |||
There was a problem hiding this comment.
Suggested change
| executeShellCommand(cli + " create " + projectDirName + " org.apache.cordova.mobilespec MobileSpec_Tests --template ./cordova-mobile-spec" + path.sep + "www"); | |
| executeShellCommand(cli + " create " + projectDirName + " org.apache.cordova.mobilespec MobileSpec_Tests --template ." + path.sep + "cordova-mobile-spec" + path.sep + "www"); |
brodycj
commented
Jun 24, 2020
| @@ -420,7 +420,7 @@ if (argv.plugman) { | |||
| // Create the project using "cordova create" | |||
| myDelete(cli_project_dir); | |||
| console.log("### Creating project mobilespec..."); | |||
| executeShellCommand(cli + " create " + projectDirName + " org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" + path.sep + "www"); | |||
| executeShellCommand(cli + " create " + projectDirName + " org.apache.cordova.mobilespec MobileSpec_Tests --template ./cordova-mobile-spec" + path.sep + "www"); | |||
There was a problem hiding this comment.
or better yet:
Suggested change
| executeShellCommand(cli + " create " + projectDirName + " org.apache.cordova.mobilespec MobileSpec_Tests --template ./cordova-mobile-spec" + path.sep + "www"); | |
| executeShellCommand(cli + ` create ${projectDirName} org.apache.cordova.mobilespec MobileSpec_Tests --template ${path.join('.', 'cordova-mobile-spec', 'www')}`); |
(not yet tested, should be considered a major change)
brodycj
commented
Jun 24, 2020
| @@ -420,7 +420,7 @@ if (argv.plugman) { | |||
| // Create the project using "cordova create" | |||
| myDelete(cli_project_dir); | |||
| console.log("### Creating project mobilespec..."); | |||
| executeShellCommand(cli + " create " + projectDirName + " org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" + path.sep + "www"); | |||
| executeShellCommand(cli + " create " + projectDirName + " org.apache.cordova.mobilespec MobileSpec_Tests --template ./cordova-mobile-spec" + path.sep + "www"); | |||
There was a problem hiding this comment.
It does not work - ./cordova-mobile-spec/createmobilespec/createmobilespec.js --android ends with the following non-descriptive output:
### Creating project mobilespec...
$ /Users/brodybits/dev/cordova-test/cordova/cordova-cli/bin/cordova create mobilespec org.apache.cordova.mobilespec MobileSpec_Tests --template ./cordova-mobile-spec/www
Warning: using prerelease version 10.0.0-dev ([email protected])
Creating a new cordova project.
/Users/brodybits/dev/cordova-test/cordova/cordova-mobile-spec/www is not a valid template
Unfortunately I did not see the error message before I raised this PR.
There was a problem hiding this comment.
This error message is from cordova-create. With the latest bunch of breaking changes there, we removed support for plain www dirs as templates. I did not take a closer look at the code here, but a simple fix could be creating a project with the default template and replacing the www dir afterwards.
brodycj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
all
Motivation and Context
issue #207
Description
use relative path for template to avoid the git failure reported in issue #207
I suspect that the git failure is due to a change in the way that Cordova CLI works together with npm.
Testing
./cordova-mobile-spec/createmobilespec/createmobilespec.js --android --debugChecklist
I added automated test coverage as appropriate for this changeCommit is prefixed with(platform)if this change only applies to one platform (e.g.(android))I've updated the documentation if necessary