Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix shell commands in document #205

Closed
wants to merge 1 commit into from

Conversation

brody4hire
Copy link

Platforms affected

all

Motivation and Context

I would like to copy-paste documented shell commands.

Description

See commit(s):

  • use double-ampersand (&&) in shell commands, as needed to work in *nix shells

Testing

  • tested the affected steps on my macOS Catalina (Unix) machine
  • test on Windows commander (cmd) shell & PowerShell

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@brody4hire brody4hire requested review from erisu and NiklasMerz June 24, 2020 16:34
Comment on lines 49 to 50
node cordova-coho/coho repo-clone -r mobile-spec -r tools -r plugins -r active-platforms
node cordova-coho/coho npm-link
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node cordova-coho/coho repo-clone -r mobile-spec -r tools -r plugins -r active-platforms
node cordova-coho/coho npm-link
node ./cordova-coho/coho repo-clone -r mobile-spec -r tools -r plugins -r active-platforms
node ./cordova-coho/coho npm-link

@brody4hire
Copy link
Author

Oops I already did this in previous PR (#204), closing this as a duplicate.

@brody4hire brody4hire closed this Jun 24, 2020
@brody4hire brody4hire deleted the brodybits-fix-shell-commands-in-document branch June 24, 2020 16:49
@brody4hire brody4hire restored the brodybits-fix-shell-commands-in-document branch June 24, 2020 16:54
@brody4hire brody4hire deleted the brodybits-fix-shell-commands-in-document branch June 24, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant