CB-10718: Update instruction #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shazron
reviewed
Jul 10, 2017
| @@ -345,16 +345,13 @@ if (argv.global) { | |||
|
|
|||
| console.log("To clone repositories:"); | |||
| console.log([" ." + path.sep + "cordova-coho" + path.sep + "coho repo-clone"].concat(repos).join(" -r ")); | |||
| if (!argv.globalplugins) { | |||
There was a problem hiding this comment.
what happened to this conditional
There was a problem hiding this comment.
I think it is needed for all condition, anything I missed?
There was a problem hiding this comment.
I checked the commands being executed in there, they make no sense at all to me. They also really don't seem to be needed if you use npm-link as added below.
janpio
reviewed
Nov 24, 2018
| console.log(" ln -s .." + path.sep + ".." + path.sep + "cordova-lib cordova-cli" + path.sep + "node_modules"); | ||
| console.log(" (cd cordova-cli && npm install)"); | ||
| } | ||
| console.log(" ." + path.sep + "cordova-coho" + path.sep + "coho -r cli -r common -r create -r fetch -r js -r serve -r lib -r plugman \"npm install\""); |
janpio
reviewed
Nov 24, 2018
| console.log(" ." + path.sep + "cordova-coho" + path.sep + "coho -r cli -r common -r create -r fetch -r js -r serve -r lib -r plugman \"npm install\""); | ||
| console.log(" ." + path.sep + "cordova-coho" + path.sep + "coho npm-link"); | ||
| platforms.forEach(function (platform) { | ||
| console.log(" (cd cordova-" + platform + " && npm install && npm link cordova-common)"); |
There was a problem hiding this comment.
Why this manual linking? Doesn't coho npm-link take care of that?
brodycj
suggested changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist