Update create doc with proper default values
#554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Hello Cordova` is the project_name default value already used or like so in cordova-android and cordova-ios (config.xml, templates, specs, etc.)
`io.cordova.helloCordova` is the package_name default value already used or like so in cordova-android and cordova-ios (config.xml, templates, specs, etc.)
Codecov Report
@@ Coverage Diff @@
## master #554 +/- ##
=========================================
Coverage ? 70.40%
=========================================
Files ? 4
Lines ? 321
Branches ? 0
=========================================
Hits ? 226
Misses ? 95
Partials ? 0 Continue to review full report at Codecov.
|
This was referenced Apr 18, 2021
breautek
approved these changes
Apr 19, 2021
NiklasMerz
reviewed
Sep 14, 2021
There was a problem hiding this comment.
I just created a new app yesterday and the default config.xml looks like this:
<?xml version='1.0' encoding='utf-8'?>
<widget id="io.cordova.hellocordova" version="1.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
<name>HelloCordova</name>
<description>
A sample Apache Cordova application that responds to the deviceready event.
</description>
<author email="[email protected]" href="http://cordova.io">
Apache Cordova Team
</author>
<content src="index.html" />
<access origin="*" />
<allow-intent href="http://*/*" />
<allow-intent href="https://*/*" />
<allow-intent href="tel:*" />
<allow-intent href="sms:*" />
<allow-intent href="mailto:*" />
<allow-intent href="geo:*" />
<platform name="android">
<allow-intent href="market:*" />
</platform>
<platform name="ios">
<allow-intent href="itms:*" />
<allow-intent href="itms-apps:*" />
</platform>
</widget>
|
@NiklasMerz you are right :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Docs
Motivation and Context
Mixed default values for
createbetween cli doc, cordova-android and cordova-ios.Description
After reviewing the various values used in cordova-android and cordova-ios for
createhere are my suggested proper defaults:io.cordova.helloCordovaHello CordovaThese are the most common values already used but not always ; see linked PRs to fix this situation (apache/cordova-ios#1100, apache/cordova-android#1213).
Testing
in cordova-android and cordova-ios respectively
Checklist
(platform)if this change only applies to one platform (e.g.(android))