feat: add cidrlist parameter to loadbalancer rule #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: acceptance tests style: remove comment docs: added cidrlist to loadbalancer_rule docs
|
Added docs and squashed previous commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual behaviour:
CIDR list parameter is critical feature when it comes to loadbalancer rules and it is missing at the moment.
When you create a loadbalancer rule using resource, it allows all CIDRs, which is not indented every time.
What was updated?
Added cidrlist parameter to loadbalancer_rule resource, so we can create rules with specific CIDRs instead of allowing everyone to access loadbalancer.
Would be great if you guys could release a new version of provider even as a minor which include this feature.