WIP: Brings back the helm code #1100
Conversation
Revert "Revert "This closes apache#830"" This reverts commit 4236ff2.
pom.xml
Outdated
| @@ -105,7 +105,7 @@ | |||
| <logback.version>1.2.3</logback.version> | |||
| <slf4j.version>1.7.25</slf4j.version> <!-- used for java.util.logging jul-to-slf4j interception --> | |||
| <!-- Must match jclouds' version. From jclouds 1.9.3+ can be any version in the range [16-20) --> | |||
| <guava.version>18.0</guava.version> | |||
| <guava.version>19.0</guava.version> | |||
There was a problem hiding this comment.
comment about helm needing v19 minimum (if that is the case)
There was a problem hiding this comment.
Yeap, all dependency upgrades in the root pom were caued because Microbean Helm requires them. :(
I will add a comment.
| <!-- (4) --> | ||
| <!-- these are the main required bundles for these features above --> | ||
| <bundle>mvn:io.fabric8/zjsonpatch/0.3.0</bundle> | ||
| <bundle>mvn:io.fabric8/kubernetes-model/${kubernetes-client.version}</bundle> | ||
| <bundle>mvn:io.fabric8/kubernetes-client/${kubernetes-client.version}/jar/bundle</bundle> | ||
| <bundle>mvn:io.fabric8/openshift-client/${kubernetes-client.version}/jar/bundle</bundle> | ||
|
|
||
| <bundle dependency='true'>wrap:mvn:org.microbean/microbean-helm/2.12.4-SNAPSHOT/jar/$Bundle-SymbolicName=microbean-helm&Bundle-Version=2.12.4-SNAPSHOT&Import-Package=*;resolution:=mandatory</bundle> |
There was a problem hiding this comment.
comment that all these are needed for microbean
|
Awesome stuff! Hellish dependencies. But if you got it working, let's merge once comments are addressed. Mainly it's comments to help us in future though there is one bit about cross-platform builds that needs to be checked. In future it might be nicer to jarjar the odd helm deps in a separate project rather than pull them all in here via OSGi. But not worth the effort if you have it working. One other question, do you have an Apache contributor license agreement @iuliana ? |
| services: | ||
| - type: org.apache.brooklyn.container.entity.kubernetes.KubernetesHelmChart | ||
| name: jenkins-helm | ||
| chartName: jenkins |
There was a problem hiding this comment.
is there a way to load a chart embedded in a BOM? that would be handy to document here.
There was a problem hiding this comment.
Not sure yet, solving the dependency hell is still ongoing.
|
Putting a break on this because of the hellish dependencies. |
Revert "Revert "This closes #830""
This reverts commit 4236ff2.
Added a few changes, played around with the version to avoid conflicts and added OSGI setup.