Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the version of cloudpickle to 2.1.x #23120

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

tvalentyn
Copy link
Contributor

Tighten the bound of cloudpickle, since cloudpickle will now be used as default in Python-on-Java xlang scenario for reasons outlined in #23119


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@tvalentyn
Copy link
Contributor Author

R: @robertwb @ryanthompson591

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #23120 (d978d86) into master (31561e2) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #23120      +/-   ##
==========================================
- Coverage   73.71%   73.62%   -0.09%     
==========================================
  Files         714      716       +2     
  Lines       95240    95299      +59     
==========================================
- Hits        70203    70164      -39     
- Misses      23740    23838      +98     
  Partials     1297     1297              
Flag Coverage Δ
python 83.40% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ks/python/apache_beam/runners/worker/statecache.py 89.69% <0.00%> (-6.47%) ⬇️
...dks/python/apache_beam/metrics/monitoring_infos.py 92.50% <0.00%> (-4.50%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 76.00% <0.00%> (-3.72%) ⬇️
sdks/python/apache_beam/internal/pickler.py 92.00% <0.00%> (-3.46%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
...ks/python/apache_beam/runners/worker/data_plane.py 87.57% <0.00%> (-1.70%) ⬇️
.../python/apache_beam/transforms/periodicsequence.py 98.38% <0.00%> (-1.62%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...eam/runners/interactive/interactive_environment.py 91.71% <0.00%> (-0.31%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@ryanthompson591 ryanthompson591 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more worried that a tight cloudpickle dependency will cause more conflicts with other libraries than dill.

I suppose we can roll this back if it causes too many problems, or better yet, vendor all our pickle libraries.

@tvalentyn tvalentyn merged commit 2a9327d into apache:master Sep 13, 2022
@tvalentyn tvalentyn deleted the cloudpicke_version_range branch September 13, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants