-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.489 #45306
base: main
Are you sure you want to change the base?
Conversation
@github-actions crossbow submit -g cpp -g r |
|
This comment was marked as outdated.
This comment was marked as outdated.
Thanks for the tip! I saw your comment in #45195 but I wanted to try the latest version as the first try. :-)
It's 1."10".458, right? |
Sorry for the typo, it's 1."11".458 |
f0dcc60
to
b41b663
Compare
ARROW_AWS_CRT_CPP_BUILD_SHA256_CHECKSUM=d445ab7a26c03a0c0cbb9d82203ee32a56c762a3cef1874783783431b8eb015a | ||
ARROW_AWS_LC_BUILD_VERSION=v1.42.0 | ||
ARROW_AWS_LC_BUILD_SHA256_CHECKSUM=8537025ebfd3884830f494166ae5f72f8aaa203d49abe650a0560a7ffedf359e | ||
ARROW_AWSSDK_BUILD_VERSION=1.11.489 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title needs an update; 1.11.488 -> 1.11.489 ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
@github-actions crossbow submit -g cpp -g wheel -g r -g linux |
Revision: 8c751c0 Submitted crossbow builds: ursacomputing/crossbow @ actions-7a18e3917f |
@github-actions crossbow submit ubuntu-jammy-amd64 |
Revision: 061a9a1 Submitted crossbow builds: ursacomputing/crossbow @ actions-1adf04401b
|
cpp/thirdparty/README.md
Outdated
the latest version automatically. You can use it like the following: | ||
|
||
```console | ||
dev/release/update.rb PRODUCT_PATTERN1 PRODUCT_PATTERN2 ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat, but the path doesn't look right, should be cpp/thirdparty/update.rb
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... Good catch! You're right.
cpp/thirdparty/update.rb
Outdated
versions_txt = File.join(__dir__, "versions.txt") | ||
versions_txt_content = File.read(versions_txt) | ||
products = parse_versions_txt_content(versions_txt_content) | ||
ARGV.each do |pattern| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have a -h/--help
option to display usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'll add it.
Rationale for this change
The current bundled version 1.10.55 was released on 2023-01-20:
https://github.com/aws/aws-sdk-cpp/releases/tag/1.10.55
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.