GH-45129: [Python][C++] Fix usage of deprecated C++ functionality on pyarrow #45189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Python
awaiting committer review
|
@github-actions crossbow submit -g python |
|
Revision: c1deb19 Submitted crossbow builds: ursacomputing/crossbow @ actions-d40040ac1a
|
|
The cython2 failure is related: the following patch would work but I don't think this should be the fix, as I am pretty sure diff --git a/python/pyarrow/src/arrow/python/common.h b/python/pyarrow/src/arrow/python/common.h
index 4a7886695e..30acf0d6ed 100644
--- a/python/pyarrow/src/arrow/python/common.h
+++ b/python/pyarrow/src/arrow/python/common.h
@@ -260,7 +260,7 @@ class SmartPtrNoGIL : public SmartPtr<Ts...> {
template <typename V>
SmartPtrNoGIL& operator=(V&& v) {
auto release_guard = optional_gil_release();
- Base::operator=(std::forward<V>(v));
+ Base::operator=(std::move(v));
return *this;
} |
|
@github-actions crossbow submit test-conda-python-3.10-cython2 |
|
Revision: 07f7acd Submitted crossbow builds: ursacomputing/crossbow @ actions-3db166d478
|
|
@github-actions crossbow submit -g python |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit -g python |
|
Revision: babbe9f Submitted crossbow builds: ursacomputing/crossbow @ actions-f876b9ef9d
|
pitrou
reviewed
Jan 8, 2025
|
@github-actions crossbow submit test-conda-python-3.10-cython2 |
|
Revision: f292cc1 Submitted crossbow builds: ursacomputing/crossbow @ actions-58dca82b3c
|
|
Ok, so the shared_ptr version works but not the unique_ptr one? In this case, we can keep using the shared_ptr approach. |
|
By the way, why do we want to support Cython 2? @jorisvandenbossche |
|
I would say we can drop the cython 2 support. |
I created an issue to track that as it is not the first time we say the same. I'll do and then I'll rebase this one. I'll ping to merge once CI is green again. |
…mentation of SmartPtrNoGIL operator
|
@github-actions crossbow submit -g python |
|
Revision: 0a1d214 Submitted crossbow builds: ursacomputing/crossbow @ actions-74244302df
|
|
CI failures are unrelated, they are failing on main and I've opened individual issues to track them. @pitrou I've rebased after the required cython bump. This should be ready to review/merge now that there's no CI failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We are using two C++ deprecated APIs:
What changes are included in this PR?
Update code to use non deprecated functions.
Are these changes tested?
Yes via CI with existing tests.
Are there any user-facing changes?
No