GH-43410: [Python] Support Arrow PyCapsule stream objects in write_dataset #43771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
awaiting merge
|
@jorisvandenbossche Do you want to update this? |
pitrou
force-pushed
the
gh-43410-arrow-pycapsule-dataset
branch
from
7a3f3d5 to
d506361
Compare
|
Rebased, will merge if green. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ad75248. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Expanding the support internally in pyarrow where we accept objects implementing the Arrow PyCapsule interface. This PR adds support in
ds.write_dataset()since we already accept a RecordBatchReader as well.What changes are included in this PR?
ds.write_dataset()andds.Scanner.from_baches()now accept any object implementing the Arrow PyCapsule interface for streams.Are these changes tested?
Yes
Are there any user-facing changes?
No