[ARIES-2161] update destroy method to be compatible with spring 6 #299
Conversation
|
Hi @f2par0 |
f2par0
changed the title
f2par0
force-pushed
the
fde/spring-fix
branch
from
b1f4597 to
a1c0cd5
Compare
blueprint/blueprint-spring/pom.xml
Outdated
| @@ -119,13 +119,13 @@ | |||
| <dependency> | |||
| <groupId>org.springframework</groupId> | |||
| <artifactId>spring-context</artifactId> | |||
| <version>4.2.2.RELEASE</version> | |||
| <version>6.1.15</version> | |||
There was a problem hiding this comment.
I checked that spring 6.x does not work with minimal java 8 that we should have in the repo
you can find the errors by running:
mvn -f blueprint/blueprint-spring clean package
or checking your branch with definition of blueprint build from #297
There was a problem hiding this comment.
yes, spring 6 is for java 17, so if java 8 support is required, the latest version is 5.3.39.
There was a problem hiding this comment.
spring 5 is end of life, it does not really make sense to support spring 5. blueprint-spring should support spring 6 (therefore need to move to jdk17) is there a way to move one project without moving all blueprint projects ?
There was a problem hiding this comment.
There are a lot of possible users who stay with Java 8 so it's better to keep all the artifacts compatible with Java 8 if possible. Especially that Spring is not often used in OSGi projects.
But personally I see the value in using the newest version of Spring.
Maybe the solution here may be creating the new artifact blueprint-spring6. Existing blueprint-spring could use newest spring 5.x version supporting Java 8. Perfectly the code should be reused between modules so the new module should only override necessary parts (if possible).
WDYT?
There was a problem hiding this comment.
Yes, but people using spring cannot stay with Java 8, so blueprint-spring itself will not be use in java 8.
Anyway I realized looking at this PR than same code can work for spring 5 and current spring 6 as well with no differences yet, so no need to separate artifacts yet, and blueprint-spring can stay with java 8
blueprint/blueprint-spring/pom.xml
Outdated
| <plugin> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <target>1.7</target> |
There was a problem hiding this comment.
java 8 should be minimal supported version
|
You may have a look to an old PR I opened for spring 5 which should work for spring 6 as well |
Problem found : the class
SpringApplicationContextinherits fromorg.springframework.context.support.AbstractApplicationContext, which had adestroymethod in version 4, but was deprecated then removed in the version 6 of spring framework.The name of the destroy method must be updated to match this new name