-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing properties to schema #10339
Conversation
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
I'm unsure why the tests are failing. |
@pottekkat Can you change this to string? The test will pass Because you can see this is a string and not number. Line 527 in 33ee8d6
|
Co-authored-by: Ashish Tiwari <[email protected]>
@Revolyssup I got this error before so I tried changing it: https://github.com/apache/apisix/actions/runs/6549717930/job/17787244082?pr=10339#step:5:287 But it should be string though. |
@Revolyssup Should we add a case where it can be either a string or a number? |
Signed-off-by: Navendu Pottekkat <[email protected]>
LGTM, That's a pretty big change. So let's make the ci pass |
dependencies = { | ||
role = { | ||
oneOf = { | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pottekkat Will you make sure that this dependency schema fits right with this[1] yaml snippet here?
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
I reverted to the same changes as in the last commit where the tests were passing in this commit: bf8bdb8 But now, the tests fail. I'm now trying by removing all changes and checking if the tests pass now and build from there. |
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
All checks pass with these changes. |
bf5775b
to
6409be4
Compare
Signed-off-by: Navendu Pottekkat <[email protected]>
It seems like the issue might have been in the etcd schema and with merging the config and deployment schemas. Checking what the issue is incrementally. |
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
4fcc98c
to
a7d2027
Compare
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
@Revolyssup please help to check |
Description
Adds missing properties to the schema so that it can be used for validating configuration files more accurately.
Also consolidates all the schemas to a single schema instead of having to validate with multiple schemas.
Checklist