ARTEMIS-5184 STOMP noLocal is scoped to session not subscription #5414
+110
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
force-pushed
the
ARTEMIS-5184
branch
from
f596686 to
0e564bd
Compare
gemmellr
reviewed
Jan 7, 2025
Comment on lines
+235
to
+237
| if (stompSubscription.isNoLocal()) { | ||
| noLocalSubscriptionCount.decrementAndGet(); | ||
| } |
There was a problem hiding this comment.
This disconnect method looks to be the only place a decrement is done...what if the subscription is explicitly unsubscribed and so this doesnt occur?
Comment on lines
1518
to
1564
| assertEquals(1, noLocalCount); | ||
| assertEquals(1, normalCount); | ||
|
|
||
| conn.disconnect(); |
There was a problem hiding this comment.
Probably worth verifying removals behave are as expected also, and perhaps sending a message after and checking the expected behaviours, e.g around the header.
There was a problem hiding this comment.
I think I got all the relevant cases.
jbertram
force-pushed
the
ARTEMIS-5184
branch
2 times, most recently
from
81906ac to
5eea931
Compare
|
I manually rebased the changes and resolved the context-only conflict (from PR 5410 having been merged), then pushed. |
|
@gemmellr, thanks! |
clebertsuconic
pushed a commit
to clebertsuconic/activemq-artemis
that referenced
this pull request
Jan 10, 2025
This closes apache#5414 (cherry picked from commit 09b8f67)
clebertsuconic
pushed a commit
to clebertsuconic/activemq-artemis
that referenced
this pull request
Jan 10, 2025
This closes apache#5414 (cherry picked from commit 09b8f67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.