ARTEMIS-5218 StompHandler HeartBeat restarted after being stopped

apache · Dec 17, 2024 · 54f9993 · 54f9993
1 parent 5c1ecea
commit 54f9993
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/...c/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java b/...c/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java
@@ -266,6 +266,8 @@ private class HeartBeater extends ActiveMQScheduledComponent {
 
       private static final int MIN_SERVER_PING = 500;
 
+      private boolean previouslyStopped = false;
+
       long serverPingPeriod = 0;
       long clientPingResponse;
       AtomicLong lastPingTimestamp = new AtomicLong(0);
@@ -321,7 +323,14 @@ private HeartBeater(ScheduledExecutorService scheduledExecutorService,
 
       public void shutdown() {
          this.stop();
+         previouslyStopped = true;
+      }
 
+      @Override
+      public void start() {
+         if (!previouslyStopped) {
+            super.start();
+         }
       }
 
       public void pinged() {

diff --git a/artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/Wait.java b/artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/Wait.java
@@ -152,6 +152,10 @@ public static void assertFalse(String failureMessage, Condition condition, final
       assertTrue(failureMessage, () -> !condition.isSatisfied(), duration, SLEEP_MILLIS);
    }
 
+   public static void assertFalse(Supplier<String> failureMessage, Condition condition, final long duration, final long sleep) {
+      assertTrue(failureMessage, () -> !condition.isSatisfied(), duration, sleep);
+   }
+
    public static void assertFalse(Condition condition, final long duration, final long sleep) {
       assertTrue(DEFAULT_FAILURE_MESSAGE, () -> !condition.isSatisfied(), duration, sleep);
    }

diff --git a/...s/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/v11/StompV11Test.java b/...s/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/v11/StompV11Test.java
@@ -2255,6 +2255,8 @@ public void testHeartBeat4() throws Exception {
       subFrame.addHeader("destination", getTopicPrefix() + getTopicName());
       subFrame.addHeader("id", "0");
 
+      Wait.assertTrue(() -> "HeartBeater is not running!! -> " + System.identityHashCode(stompFrameHandler.getHeartBeater()), () -> stompFrameHandler.getHeartBeater().isStarted(), 5000, 100);
+
       ClientStompFrame f = conn.sendFrame(subFrame);
       f = conn.sendFrame(subFrame);
 
@@ -2269,7 +2271,7 @@ public void testHeartBeat4() throws Exception {
 
       Wait.assertEquals(0, () -> server.getRemotingService().getConnections().size());
 
-      Wait.assertFalse("HeartBeater is still running!!", () -> stompFrameHandler.getHeartBeater().isStarted());
+      Wait.assertFalse(() -> "HeartBeater is still running!! -> " + System.identityHashCode(stompFrameHandler.getHeartBeater()), () -> stompFrameHandler.getHeartBeater().isStarted(), 5000, 100);
    }