Re-enable deletes aodn/backlog/issues/229 #285
Conversation
|
Shouting now at sysadmins now if they attempt to delete
|
|
(Edited) @xhoenner wasn't there something to do with enabling soft-deletes? Eg. so that a column in the database row gets marked as deleted, rather than actually deleting the row. Was that encompassed/related to this work? |
|
@Julian For better or worse this pull request follows the requirements of aodn/backlog#229 only |
|
The delete functionality has been disabled precisely because it was threatening the integrity of the data in the database. What @jkburges suggested in #204 was to introduce a soft delete feature to avoid the inadvertent loss of data. Simply re-enabling the delete functionality will cause more problems than anything else, see #202 which forced us to restore a backup of the db. I'd say that the requirements laid out in https://github.com/aodn/backlog/issues/229 are not representative of #204 and therefore need to be refined @pblain. |
|
@xhoenner , Andre asked for the delete feature to be re-enabled: #204 (comment) We are doing our best to fix bugs in the existing feature set - but we are not adding new features. Up to you whether you want the delete feature restored to function as it was designed (i.e. hard delete), or to leave it disabled. |
|
The reality is that I need to get the delete function back asap to clean up the database, e.g. double entries, wrong entries, etc. There shouldn't be a delete button for everyone but for me as a sysadmin. Thanks for sorting this out! |
|
I'm aware that @astecken wants the delete functionality re-enabled but @jkburges disabled it originally to prevent the loss of data: #204 (comment). I thought it was clear in your mind that fixing #204 meant proceeding as @jkburges suggested and implement the soft-delete functionality since just re-enabling the delete functionality threatens the integrity of the database. I am surprised that we're having this disagreement at this stage of the iteration, I would have thought that the details of getting #204 fixed would have come up during conversations with Rog, @jachope and @smancini, and then again during the developers' planning meeting. I don't think it is wise to proceed without the soft-delete feature, it's just a recipe for wasting developers' time with VITs to restore the AATAMS db. As explained to @smancini, providing @astecken with a way to delete content through the web app (which in this case requires a new feature or a remodel of the existing delete functionality depending on how you want to look at things) is the only approach we have to knock down two (#240 and #241) of the remaining five high priority bugs. |
|
For my part, I believe this is a matter for JPSR. |
|
Closing for now, following https://github.com/aodn/backlog/issues/229 |
No description provided.