Address regressions introduced in gce test net setup with image update to latest ubuntu #3926
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregcusack
reviewed
Dec 4, 2024
| validatorBootDiskSizeInGb=500 | ||
| validatorBootDiskSizeInGb=100 |
There was a problem hiding this comment.
why do we need a smaller boot disk size now?
There was a problem hiding this comment.
not sure why we'd need 500 GB per node. If someone really really needs it, they can set that in their own config. Testnet runs fine with 100 GB disk with 90 GB of space to spare. The only node that needs huge amount of disk is the bootstrap that builds agave, but that is hardwired to use more space.
Comment on lines
+8
to
+9
| apt-get update | ||
| apt-get --assume-yes install at |
There was a problem hiding this comment.
are we installing at since it is no longer in the base image of ubuntu 22?
| apt-get --assume-yes install libssl1.1 | ||
| # apt-get --assume-yes install libssl1.1 |
There was a problem hiding this comment.
can we remove this line instead of commenting out? and are we removing since libssl 3 comes pre installed with ubuntu 22?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#3911 introduced regressions that make gce.sh and associated scripts to fail.
Summary of Changes
Remove the openssl1.1 install command
Update the gce.sh to pull in the needed packages that are no longer in base image