[secp256r1] Add bench logic #3825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
force-pushed
the
secp256r1/bench
branch
from
91af228
to
e9b3694
Compare
joncinque
reviewed
Dec 2, 2024
There was a problem hiding this comment.
The change looks good to me! Once the transaction type has been extracted, we should be able to move all of these benches into their respective crates.
We just need to make sure that the openssl-vendored is always activated when running the bench. Can you add that to all of the calls of cargo bench -p solana-sdk or cargo bench --manifest-path sdk/Cargo.toml?
Looks like that means changing .github/workflows/benchmark.yml, ci/bench/part2.sh, and ci/test-bench.sh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The secp256r1 precompile does not have bench code.
Summary of Changes
Add bench logic similar to the ones pertaining to ed25519 and secp256k1 precompiles.
Fixes #