-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract solana-feature crate #3120
Conversation
058d94b
to
c713f2b
Compare
774c4c6
to
e44bd02
Compare
5d4e2da
to
d5cc897
Compare
b7f92d7
to
abd112e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the feature gate program's equivalent of an "interface" crate, can we call it solana-feature-gate-interface
? We can eventually move this into https://github.com/solana-program/feature-gate/, but I don't think it's necessary just yet.
cc @buffalojoec does that sound ok?
Otherwise, it looks good to me!
abd112e
to
672dfed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! @yihau can you accept solana-feature-gate-interface
?
234e3b4
to
0307cff
Compare
0307cff
to
2edba02
Compare
Yeah I don't want to block SDK breakup work, so this is okay for now, but I do think most (if not all) of this should go in the program's client, so maybe we should consider deprecating it? We can publish the Rust client anytime. |
Since the feature gate program depends on these types, it would create a sort of circular dependency for the program. Program depends on client, and client is generated from program. We've opted for creating "interface" crates which just contain state / instruction / error types, so that IDLs can be generated. So I'd actually want to move more stuff into the interface crate from the program! |
Problem
solana_program::feature
imposes asolana_program
dep onsolana_rpc_client
Summary of Changes