Improve frozen abi dx a bit and document it #2131
Conversation
ryoqun
force-pushed
the
frozen-abi-updates
branch
from
ae4d17f
to
1bd6473
Compare
ryoqun
changed the title
|
I assume this is a response to my discord comment here: https://discord.com/channels/428295358100013066/439194979856809985/1261428595814039603 While these changes fix it for my specific case of changing the hash function, I am still curious about the larger question of why the Bank needs a frozen Abi at all. |
ryoqun
changed the title
hehe, thanks for jumping in. i was too early to mark this pr out of draft.. I pushed a commit for the explanation. is there specific questions not answered by this still?: 99cdd64 |
Had responded on discord since you commented there. But this explanation, to me, seems to justify that its' necessary because of the test structure...which we could also change to make that not required. |
yeah. as written in the commit, i was reluctant to copy all the type arguments of |
frozen-abi/src/abi_example.rs
Outdated
| @@ -431,6 +431,28 @@ impl< | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(not(target_os = "solana"))] | |||
| impl<T: Clone + std::cmp::Eq + std::hash::Hash + AbiExample, S: Clone + AbiExample> AbiExample | |||
There was a problem hiding this comment.
given the other changes, think we can drop adding this.
There was a problem hiding this comment.
done by dropping the commit from the pr.
ryoqun
force-pushed
the
frozen-abi-updates
branch
2 times, most recently
from
367d6c6
to
da0afa1
Compare
ryoqun
force-pushed
the
frozen-abi-updates
branch
from
da0afa1
to
24dbe7e
Compare
|
looks good to me but I would like to wait for @apfitzge to have a chance to take a look! |
Problem
Frozen abi needs some love periodically.
Summary of Changes
It's another time again. This pr is cumulative one containing multiple changes relating to frozen abi.
See individual commits.