switch to regex::Regex #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmm1
pushed a commit
that referenced
this pull request
Nov 9, 2024
Based on openai#331 Uses Regex in _encode_ordinary_native instead of fancy-regex, to get a 6x speedup. To make the regex patterns compatible with Regex, drops part of thpatterns for whitespaces, and handles the whitespaces with scripting instead of regex. Still with exact same output. _encode_native calls _encode_ordinary_native_impl directly (_encode_ordinary_native is a wrapper of _encode_ordinary_native now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on https://github.com/openai/tiktoken/pull/331/files
closes #21