Sync change from Klutch upstream #35
Open
+1,568
−1,289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulhaseeb3
requested review from
mkfdoherty,
iliasmavridis,
jcartossa,
rfashwall-anynines and
m-hofmann-a9s
as code owners
abdulhaseeb3
force-pushed
the
sync-changes
branch
4 times, most recently
from
b04e575 to
5bc1534
Compare
Our confighealth reconciler performs a health check HTTP request to the anynines service broker and writes the result to the providerconfig's status field. Previously, one Golang context with a timeout was used for both the health check and the subsequent patching of providerconfig's status. However, if the health check request exceeded the timeout, the patching of the status field could never succeed. client-go's Patch() method would error with a "context deadline exceeded" error message. This commit introduces a separate sub-context for the health check request, which has an explicit timeout, while using the parent context (which does not time out) for patching the status field.
abdulhaseeb3
force-pushed
the
sync-changes
branch
from
5bc1534 to
a700881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: Only users listed in the CODEOWNERS file can approve PRs!