Skip to content

Commit

Permalink
Merge branch 'ah/autoconf-fixes'
Browse files Browse the repository at this point in the history
"./configure --with-expat=no" did not work as a way to refuse use
of the expat library on a system with the library installed, which
has been corrected.

* ah/autoconf-fixes:
  configure.ac: always save NO_ICONV to config.status
  configure.ac: don't overwrite NO_CURL option
  configure.ac: don't overwrite NO_EXPAT option
  • Loading branch information
gitster committed Aug 2, 2023
2 parents fea92e4 + fb8f726 commit 99acb0f
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,8 @@ fi
# git-http-push are not built, and you cannot use http:// and https://
# transports.

if test -z "$NO_CURL"; then

GIT_STASH_FLAGS($CURLDIR)

AC_CHECK_LIB([curl], [curl_global_init],
Expand All @@ -554,6 +556,8 @@ AC_CHECK_LIB([curl], [curl_global_init],

GIT_UNSTASH_FLAGS($CURLDIR)

fi

GIT_CONF_SUBST([NO_CURL])

if test -z "$NO_CURL"; then
Expand Down Expand Up @@ -581,6 +585,8 @@ fi
# Define NO_EXPAT if you do not have expat installed. git-http-push is
# not built, and you cannot push using http:// and https:// transports.

if test -z "$NO_EXPAT"; then

GIT_STASH_FLAGS($EXPATDIR)

AC_CHECK_LIB([expat], [XML_ParserCreate],
Expand All @@ -589,6 +595,8 @@ AC_CHECK_LIB([expat], [XML_ParserCreate],

GIT_UNSTASH_FLAGS($EXPATDIR)

fi

GIT_CONF_SUBST([NO_EXPAT])

#
Expand Down Expand Up @@ -636,14 +644,15 @@ LIBS="$old_LIBS"
GIT_UNSTASH_FLAGS($ICONVDIR)

GIT_CONF_SUBST([NEEDS_LIBICONV])
GIT_CONF_SUBST([NO_ICONV])

if test -n "$NO_ICONV"; then
NEEDS_LIBICONV=
fi

fi

GIT_CONF_SUBST([NO_ICONV])

#
# Define NO_DEFLATE_BOUND if deflateBound is missing from zlib.

Expand Down

0 comments on commit 99acb0f

Please sign in to comment.