Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the style error for the too long guide #282

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

sunsunmonkey
Copy link
Contributor

image

@hustcc
Copy link
Member

hustcc commented Feb 4, 2024

原样式是什么样的?有对应的关联 issue 吗?

@sunsunmonkey
Copy link
Contributor Author

sunsunmonkey commented Feb 4, 2024

关联

原来就是截图那样,他超出部分就被hidden了嘛

@hustcc
Copy link
Member

hustcc commented Feb 4, 2024

是不是去掉 overflow 就好了,保留 max height ,这样超处就有滚动条了。

@sunsunmonkey
Copy link
Contributor Author

但那样就是两个滚动条叠在一起很奇怪

@sunsunmonkey
Copy link
Contributor Author

image
要滚动条貌似还要加个overflow: auto

@sunsunmonkey
Copy link
Contributor Author

image
看了一下语雀好像确实也是做了个滚动条

@hustcc
Copy link
Member

hustcc commented Feb 5, 2024

auto 的话,没超出不会有滚动条吧?

@sunsunmonkey
Copy link
Contributor Author

是这样的

@hustcc hustcc merged commit 8d602bc into antvis:v3 Feb 5, 2024
@hustcc
Copy link
Member

hustcc commented Feb 5, 2024

可以把关联的 issue 地址回复到这里。

@sunsunmonkey
Copy link
Contributor Author

这个是我自己发现的,没看到issue

@sunsunmonkey
Copy link
Contributor Author

sunsunmonkey commented Feb 5, 2024

@hustcc
Copy link
Member

hustcc commented Feb 5, 2024

可以验证下是不是,是的话,就可以关闭这个问题了

@sunsunmonkey
Copy link
Contributor Author

应该就是

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants