Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(g): 修复列宽很小时多行文本渲染错误 #3060

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

G 的 bug, 同步更新并增加单测, 当列宽很小, 一行仅能展示一个字时, 文本渲染有问题 see antvis/G#1887

image

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Jan 2, 2025 6:37am

Copy link
Contributor

github-actions bot commented Jan 2, 2025

你好 @lijinke666,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

Copy link

Walkthrough

此PR修复了当列宽很小时多行文本渲染错误的问题。通过更新依赖包和增加单元测试,确保在列宽很小且一行仅能展示一个字的情况下,文本渲染正常。

Changes

文件 概要
packages/s2-core/tests/spreadsheet/snapshots/multi-line-text-spec.ts.snap 更新了快照测试以反映文本渲染的修复。
packages/s2-core/tests/spreadsheet/multi-line-text-spec.ts 添加了新的单元测试以验证文本换行异常不再抛出。
packages/s2-core/package.json 更新了依赖版本以修复文本渲染问题。
pnpm-lock.yaml 更新了依赖锁文件以匹配新的依赖版本。

@github-actions github-actions bot added pr(fix) bug fix next 2.0-next 版本的问题 labels Jan 2, 2025
@@ -1252,5 +1252,43 @@ describe('SpreadSheet Multi Line Text Tests', () => {

matchCellStyleSnapshot();
});

// https://github.com/antvis/G/pull/1887
test('should not throw text wrapping exception', async () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确保在测试中正确设置列宽,以验证文本渲染问题的修复效果。

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.77%. Comparing base (ecdc9c8) to head (6e4851f).
Report is 581 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3060      +/-   ##
==========================================
  Coverage   75.77%   75.77%              
==========================================
  Files         257       51     -206     
  Lines       11994     1490   -10504     
  Branches     2464      284    -2180     
==========================================
- Hits         9088     1129    -7959     
+ Misses       1398      210    -1188     
+ Partials     1508      151    -1357     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Size Change: +7 B (0%)

Total Size: 619 kB

Filename Size Change
./packages/s2-core/dist/s2-extends.min.js 154 kB +1 B (0%)
./packages/s2-core/dist/s2.min.js 257 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@lijinke666 lijinke666 merged commit aca03ac into next Jan 2, 2025
14 of 16 checks passed
@lijinke666 lijinke666 deleted the fix-text branch January 2, 2025 06:53
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants