-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(g): 修复列宽很小时多行文本渲染错误 #3060
fix(g): 修复列宽很小时多行文本渲染错误 #3060
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
你好 @lijinke666,非常感谢你的贡献. Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
Walkthrough此PR修复了当列宽很小时多行文本渲染错误的问题。通过更新依赖包和增加单元测试,确保在列宽很小且一行仅能展示一个字的情况下,文本渲染正常。 Changes
|
@@ -1252,5 +1252,43 @@ describe('SpreadSheet Multi Line Text Tests', () => { | |||
|
|||
matchCellStyleSnapshot(); | |||
}); | |||
|
|||
// https://github.com/antvis/G/pull/1887 | |||
test('should not throw text wrapping exception', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确保在测试中正确设置列宽,以验证文本渲染问题的修复效果。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3060 +/- ##
==========================================
Coverage 75.77% 75.77%
==========================================
Files 257 51 -206
Lines 11994 1490 -10504
Branches 2464 284 -2180
==========================================
- Hits 9088 1129 -7959
+ Misses 1398 210 -1188
+ Partials 1508 151 -1357 ☔ View full report in Codecov by Sentry. |
Size Change: +7 B (0%) Total Size: 619 kB
ℹ️ View Unchanged
|
🎉 This PR is included in version @antv/s2-v2.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🐛 Bugfix
📝 Description
G 的 bug, 同步更新并增加单测, 当列宽很小, 一行仅能展示一个字时, 文本渲染有问题 see antvis/G#1887
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge