Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 解决移动端下,树形结构展开、收起交互失效的问题 #3039

Merged
merged 9 commits into from
Dec 13, 2024

Conversation

gb853940223
Copy link
Contributor

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

背景:
使用Antv S2进行移动端业务开发,左侧树形图的展收、收起交互失效。
改动点:
在移动端下,左侧树形结构展开、收起交互,不能将整个单元格作为热区,否则会影响到绑定到整个单元格的其他事件,而是适度增加Icon面积,仍然以Icon为交互热区。
问题:
左侧树形结构的展开、收起交互正常,同时又不会影响绑定到整个单元格的其他事件

🖼️ Screenshot

改动前:
https://github.com/user-attachments/assets/7378823f-60bf-484a-b6fd-20a0d588a1e3
改动后:
https://github.com/user-attachments/assets/b5779263-ca82-4ea2-99bd-d9442034223f

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Dec 13, 2024 6:15am

@gb853940223 gb853940223 changed the title Mobile tap fix: 解决移动端下,树形结构展开、收起交互失效的问题 Dec 13, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Dec 13, 2024
@github-actions github-actions bot added the pr(fix) bug fix label Dec 13, 2024
@lijinke666 lijinke666 merged commit a97625c into antvis:next Dec 13, 2024
13 of 15 checks passed
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v2.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants