fix: 解决移动端下，树形结构展开、收起交互失效的问题 #3037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lijinke666
reviewed
Dec 12, 2024
| this.emitCollapseEvent(); | ||
| }); | ||
| } | ||
| // if (isMobile()) { |
| @@ -519,4 +520,20 @@ export abstract class HeaderCell< | |||
| public getActionIcons() { | |||
| return this.actionIcons || []; | |||
| } | |||
|
|
|||
| protected getActionIconOffset(iconSize: number) { | |||
There was a problem hiding this comment.
Suggested change
| protected getActionIconOffset(iconSize: number) { | |
| protected getActionIconOffset(iconSize: number) { | |
| // 移动端的时候，将icon变大，从而增加触发交互的面积 | |
| if (isMobile()) { | |
| return { | |
| offsetXY: iconSize / 4; | |
| offsetWH: iconSize / 2; | |
| } | |
| } | |
| return { | |
| offsetXY: 0, | |
| offsetWH: 0, | |
| }; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
背景：
使用Antv S2进行移动端业务开发，左侧树形图的展收、收起交互失效。
改动点：
在移动端下，左侧树形结构展开、收起交互，不能将整个单元格作为热区，否则会影响到绑定到整个单元格的其他事件，而是适度增加Icon面积，仍然以Icon为交互热区。
问题：
左侧树形结构的展开、收起交互正常，同时又不会影响绑定到整个单元格的其他事件
🖼️ Screenshot
改动前：
https://github.com/user-attachments/assets/7378823f-60bf-484a-b6fd-20a0d588a1e3
改动后：
https://github.com/user-attachments/assets/b5779263-ca82-4ea2-99bd-d9442034223f
🔗 Related issue link
🔍 Self-Check before the merge