Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复在维值缺失场景下导出数据占位符未解析的问题 #3027

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Dec 11, 2024

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

背景见: https://github.com/antvis/S2/pull/2829/files

这个是 1.x 已经修复过的, 当时同步过来由于 2.x 整体导出链路变了, 忘记修改了.

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Dec 11, 2024 6:57am

@github-actions github-actions bot added next 2.0-next 版本的问题 pr(fix) bug fix labels Dec 11, 2024
@@ -21,19 +21,19 @@ exports[`Miss Dimension Values Tests should replace empty dimension value placeh

exports[`Miss Dimension Values Tests should replace empty dimension value placeholder when copy original data 1`] = `
"first second third number
总计 $$empty_field_value$$ $$empty_field_value$$ 1732771
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

快照是错的

Copy link
Contributor

Size Change: +23 B (0%)

Total Size: 618 kB

Filename Size Change
./packages/s2-core/dist/s2-extends.min.js 154 kB +13 B (+0.01%)
./packages/s2-core/dist/s2.min.js 257 kB +10 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@lijinke666 lijinke666 merged commit 6e63b97 into next Dec 13, 2024
13 of 15 checks passed
@lijinke666 lijinke666 deleted the fix-miss-dimension branch December 13, 2024 02:00
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant