Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复明细表自定义行高时多行文本未自适应调整 #3017

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

  style: {
      rowCell: {
        maxLines: 3,
        height: 20,
      },
    },
  });

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Dec 5, 2024 9:25am

@github-actions github-actions bot added pr(fix) bug fix next 2.0-next 版本的问题 labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Size Change: +59 B (+0.01%)

Total Size: 618 kB

Filename Size Change
./packages/s2-core/dist/s2-extends.min.js 154 kB +18 B (+0.01%)
./packages/s2-core/dist/s2.min.js 257 kB +41 B (+0.02%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action


return isNumber(this.getCustomRowCellHeight(node)) || isCustomDefaultHeight;
return (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还原之前的更改

@lijinke666 lijinke666 merged commit 8a55fa6 into next Dec 5, 2024
7 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-table-text-wrap branch December 5, 2024 09:59
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants