Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复下钻组件展示错误操作 icon & 兼容低版本 menu 写法 #3011

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

items: [
    {
      key: 'custom-d',
      label: '操作4',
      icon: 'EyeOutlined',
      visible: (cell) => {
        return cell instanceof DataCell;
      },
    },
 ]

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Dec 4, 2024 6:15am

@github-actions github-actions bot added the pr(fix) bug fix label Dec 4, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Dec 4, 2024
@@ -119,12 +127,7 @@ export const DrillDown: React.FC<DrillDownProps> = React.memo(
/>
)}
{extra}
<Menu
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提供 renderMenu hook, 自定义 Menu 组件, 兼容低版本 antd 不支持 <Menu items={} /> 写法的问题

const tooltipProps = customMerge<TooltipRenderProps>(
{
options: {
operator: operation,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

保持和 v1 一致, 每次主动调用 s2.showTooltip 时, 以传入的配置为准, 而不是每次都额外携带默认配置中的

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Size Change: 0 B

Total Size: 618 kB

ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2-extends.min.js 154 kB
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-core/dist/s2.min.js 256 kB
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@lijinke666 lijinke666 merged commit 7d171f0 into next Dec 4, 2024
7 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-drill-menu branch December 4, 2024 06:21
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-components-v2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants