-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复下钻组件展示错误操作 icon & 兼容低版本 menu 写法 #3011
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -119,12 +127,7 @@ export const DrillDown: React.FC<DrillDownProps> = React.memo( | |||
/> | |||
)} | |||
{extra} | |||
<Menu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
提供 renderMenu hook, 自定义 Menu 组件, 兼容低版本 antd 不支持 <Menu items={} />
写法的问题
const tooltipProps = customMerge<TooltipRenderProps>( | ||
{ | ||
options: { | ||
operator: operation, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
保持和 v1 一致, 每次主动调用 s2.showTooltip
时, 以传入的配置为准, 而不是每次都额外携带默认配置中的
Size Change: 0 B Total Size: 618 kB ℹ️ View Unchanged
|
🎉 This PR is included in version @antv/s2-v2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-react-v2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-react-components-v2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🐛 Bugfix
📝 Description
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge