Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复角头存在多行文本时未自动撑开列头高度的问题 #3010

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

  1. 列高采样是基于列头单元格, 未考虑当前行存在角头换行的场景, 导致只有角头有换行文本时, 列高不正确的问题
cornerCell: {
  maxLines: 10,
},
colCell: {
  maxLines: 1,
}
  1. 存在自定义高度时, 应该和手动拖拽一样, 动态调整 maxLines, 保证展示合理性
  colCell: {
    height: 20,
    maxLines: 1,
  }

🖼️ Screenshot

Before After
image image
image image
image image
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Dec 4, 2024 3:56am

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Dec 3, 2024
@github-actions github-actions bot added the pr(fix) bug fix label Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Size Change: +1.06 kB (+0.17%)

Total Size: 618 kB

Filename Size Change
./packages/s2-core/dist/s2-extends.min.js 154 kB +324 B (+0.21%)
./packages/s2-core/dist/s2.min.js 256 kB +740 B (+0.29%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@lijinke666 lijinke666 changed the title fix: 修复角头存在多行文本时为自动撑开列头高度的问题 fix: 修复角头存在多行文本时未自动撑开列头高度的问题 Dec 4, 2024
@lijinke666 lijinke666 merged commit 0b79f27 into next Dec 4, 2024
7 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-corner-text-wrap branch December 4, 2024 05:54
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants