Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 解决移动端下,树形结构展开、收起交互失效的问题。 #3005

Closed
wants to merge 2 commits into from

Conversation

gb853940223
Copy link
Contributor

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

背景:
使用Antv S2进行移动端业务开发,左侧树形图的展收、收起交互失效。
改动点:
在移动端下,左侧树形结构展开、收起交互,不能将整个单元格作为热区,否则会影响到绑定到整个单元格的其他事件,而是适度增加Icon面积,仍然以Icon为交互热区。
问题:
左侧树形结构的展开、收起交互正常,同时又不会影响绑定到整个单元格的其他事件

🖼️ Screenshot

Before After
default.mp4

| ✅

default.mp4

|

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Dec 4, 2024 2:21am

@lijinke666
Copy link
Member

否则会影响到绑定到整个单元格的其他事件

这个具体是什么场景?

@gb853940223
Copy link
Contributor Author

gb853940223 commented Dec 4, 2024

@lijinke666 在移动端场景下,自定义目录树,手指点击单元格或者加减号,并没有正常展开或收起,如第一个视频。第二个视频是修复之后效果。

y: iconY,
width: size!,
height: size!,
x: iconX - offsetXY,
Copy link
Member

@lijinke666 lijinke666 Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个热区的处理建议在基类 HeaderCell 上抽一个公用方法, 和上面 corner-cell 公用

});

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接删掉吧, 不需要注释 L#188-L#199

x: iconX - offsetXY,
y: iconY - offsetXY,
width: size + offsetWH,
height: size + offsetWH,
fill,
},
isCollapsed,
onClick: () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要像 corner-cell 一样处理吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants