Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复明细表自定义列头时开启文本换行, 单元格高度错误的问题 close #2955 #2968

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

📝 Description

#2705 中修复明细表单列头, 单测未覆盖自定义列头的场景, 先计算宽度, 再计算高度, 确保计算多行文本时能获取到正确的最大文本宽度

const s2Options = {
  style: {
    colCell: {
      maxLines: 10,
    },
  }
}

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Nov 8, 2024 7:41am

@lijinke666 lijinke666 linked an issue Nov 8, 2024 that may be closed by this pull request
5 tasks
@github-actions github-actions bot added pr(fix) bug fix next 2.0-next 版本的问题 labels Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Size Change: +1 B (0%)

Total Size: 336 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 236 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.9 kB
./packages/s2-react/dist/style.min.css 3.77 kB
./packages/s2-vue/dist/index.min.js 23 kB
./packages/s2-vue/dist/style.min.css 1.85 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Nov 8, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Nov 8, 2024
@wjgogogo wjgogogo merged commit ca1f7e8 into next Nov 8, 2024
7 of 9 checks passed
@wjgogogo wjgogogo deleted the fix-2955 branch November 8, 2024 09:42
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Nov 8, 2024
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤔希望这里的高度是单行文本的高度
2 participants